Hanami-DB 2.2 is not compatible with rom-repository 5.4

[wuarmin]

Describe the bug

Due to yesterday's refactoring in repository/relation_reader.rb, the method ROM::Repository#set_relation, which is used in hanami/db, no longer exists. It was renamed to prepare_relation.

https://github.com/hanami/db/blob/344a14933f7e1c66304f353119d3467d15ae997e/lib/hanami/db/repo.rb#L43

To Reproduce

bundle update
bundle exec rspec spec/slices/my_slice/repos/user_repo_spec.rb

Backtrace:

 NoMethodError:
       undefined method 'set_relation' for an instance of MySlice::Repos::UserRepo
     # /usr/local/bundle/gems/hanami-db-2.2.0/lib/hanami/db/repo.rb:42:in 'Hanami::DB::Repo#initialize'
     # /usr/local/bundle/gems/rom-repository-5.4.0/lib/rom/repository/class_interface.rb:70:in 'Class#new'
     # /usr/local/bundle/gems/rom-repository-5.4.0/lib/rom/repository/class_interface.rb:70:in 'ROM::Repository::ClassInterface#new'
     # /usr/local/bundle/gems/hanami-2.2.1/lib/hanami/extensions/db/repo.rb:72:in 'block in define_new'
     # /usr/local/bundle/gems/hanami-2.2.1/lib/hanami/extensions/db/repo.rb:72:in 'block in define_new'
     # ./spec/slices/my_slice/repos/user_repo_spec.rb:17:in 'block (4 levels) in <top (required)>'

@flash-gordon What's the best way to bring back set_relation? Renaming prepare_relation to set_relation would fix the issue.

At the moment, every Hanami-db-app, which updates deps will run into this error.
It should be noted that set_relation was marked as a private api.

thanks

[flash-gordon]

@wuarmin, thanks for reporting! Yes, since it was marked as private, I didn't think it was in use. We can then add an alias and deprecate it. I'll take a look later today and cut a release.

[flash-gordon]

@wuarmin I pushed rom-repo + rom 5.4.1 with deprecation and submitted a patch to hanami hanami/db#16

[wuarmin]

@flash-gordon thanks for the quick fix. It works now, and I see the deprecation.