Disable new default auto-indent at included partials #858

majodev · 2014-09-03T13:44:10Z

Handlebars >v2.0.0-alpha.4 introduced a new default indentation handling at partials, namely "Partials that are standalone will now indent their rendered content" (source). This might cause unexpected behavior when upgrading from previous versions, is there a flag to restore the old handling?

Detailed explanation / self reproduce

Thanks in advance! :)

The text was updated successfully, but these errors were encountered:

kpdecker · 2014-09-04T11:48:40Z

What sort of failures have you seen? It's not too hard to implement a flag for this but I want to make sure I understand the failure case.

majodev · 2014-09-05T10:17:52Z

It's not a failure by itself, I only think such a flag might be convenient for compiling partials/templates, that depend on the old handling.

Use case: A partial that inserts content, which holds transformed 'Markdown to HTML'-content and has code tags within it. The content within these code tags has newlines and these lines should not get automatically intended to the outer template's indentation level, where the partial gets inserted.

Of course it's rather easy to workaround this problem by inserting every partial that requires the old handling at zero indentation in outer template, however, I thought such a flag might be convenient for folks, who want to upgrade to newer Handlebars versions but rely on the old indentation handling and don't want to modify their templates after updating.

Anyways, I'm unsure if the old handling was compliant to the Mustache spec, so it might be better to just accept it as it is now and close my issue. :)

joshterrell805 · 2014-09-06T19:51:13Z

Verification: I have exactly this problem right now.

helper '/posts/post'

<h1 class='title'>{{title}}</h1>
<div class='body'>{{{body}}}</div>

main template

<body>
   {{> '/header'}}
   <div class='post row small-11 small-centered columns'>
      {{> '/posts/post' this}}
   </div>
   {{> '/footer'}}
</body>

rendered html

   <div class='post row small-11 small-centered columns'>
      <h1 class='title'>Content Indexing</h1>
      <div class='body'><h3 id="problem">Problem</h3>
      <p>I want to build an index page which shows the latest <code>X</code> posts. I need a function which returns an <code>index</code> of the posts.</p>
      <pre><code class="lang-js">index = [
         &quot;newest post&#39;s title&quot;,
         &quot;second-newest post&#39;s title&quot;,
         ...
      ];
      </code></pre>

Screwed up indentation in displayed code:

kevinrenskers · 2014-09-11T09:50:28Z

I had the exact same issue too: https://github.com/kevinrenskers/raml2html/issues/66

75lb · 2014-09-20T13:22:42Z

this auto-indent feature should be optional because it completely breaks generation of whitespace-sensitive output like

the content of html <pre> tags
markdown

My templates generates a lot of the above so i'm currently i'm stuck on v2.0.0-alpha.4 until this flag lands on master..

shenanigans · 2014-09-28T01:32:11Z

I, too, need this feature. How much of a pain would it be to specify that a single 'stache replacement be unindented, using a syntax cue of some kind? i.e. {{|> preformattedHelper}}

ErisDS · 2014-10-30T11:39:52Z

Ghost users are also suffering from issues with the auto-indentation. Here's a forum thread where we figured out that this was the cause of a problem a user was seeing with syntax highlighting on their Ghost blog.

Essentially, the auto indent causes extra indentation to be added to any <pre> blocks inside the partial, so the content of the <pre> is rendered WITH the extra indentation.

I guess it would help to submit a PR with a failing test or something for this?

majodev · 2014-10-30T12:13:04Z

@ErisDS: The problem is, that it would make no sense to explicitly exclude pre blocks from this new indentation handling within the handlebars library, as the engine simply shouldn't make these assumptions (and handlebars is not limited to work with HTML blocks only). However, the addition of a test would be excellent to secure this handling in the future.

I like the idea of @shenanigans' {{|> preformattedHelper}} to disable the feature at a block level, but would also love to see a global option, so former templates that rely on the old behavior work as expected again by setting a single flag (e.g. within the complile method).

@kpdecker I really feel this issue reached a critical mass when it comes to backward compatibility. I'm aware of the long discussions this new indentation handling has caused in former pull requests, it's a tough problem as people really have a different opinion on how this should work by default. Is this new behavior dictated by the mustache spec (#811)?

ErisDS · 2014-10-30T12:34:06Z

I understand completely and wouldn't expect that the behaviour should apply differently to <pre> blocks. I just wanted to come along with a real world example of how this change is causing hard to diagnose bugs in existing software.

I think for our use case, a global flag makes most sense, as I think we'd want to disable this feature across all themes. Trying to communicate this subtlety to theme developers would be incredibly difficult, and I'm not sure what benefit the indentation provides in themes other than clean source.

ErisDS · 2014-10-30T13:07:22Z

Here's a JSFiddle that demonstrates the change in behaviour:

Latest Handlebars: http://jsfiddle.net/6d7wbfna/1/
Handlebars 1.3.0: http://jsfiddle.net/6d7wbfna/

ErisDS · 2014-10-30T13:29:08Z

I'm left wondering why this behaviour was changed in the first place?

As far as I can tell, it was purely for aesthetic reasons (please correct me if I am wrong). I appreciate clean source as much as the next person, but this has fundamentally changed the mapping between handlebars and HTML far beyond an aesthetic source code level improvement.

Although there are many possible representations of any given piece of HTML with variations of whitespace that are visually (and functionally) equivalent, this has changed the output from handlebars to use a representation of HTML that is no longer visually or functionally equivalent to the previous version. This is, therefore, a breaking change, and I think warrants further thought beyond just putting in any sort of flag.

This change forces every person who is crafting templates in handlebars to consider the whitespace within the entire tree of nested partials in order to determine if the output from a <pre> or <textarea> tag will render as expected. In short, we can no longer reliably determine what HTML Handlebars will output.

If the only reason for this change is an aesthetic one, then I believe it's worth considering reverting the change.

The comment by @wycats here (I know it was from a while ago) expressed this concern, including the problem that doing this with or without a flag would cause, and I'd like to reiterate that concern.

kpdecker · 2014-10-30T15:06:34Z

This feature was changed in order to match the mustache spec, which another subset of users was requesting while 2.x was being developed. We are in a position where every single change made or not to the language will piss someone off.

Regarding pre comments: Handlebars is agnostic to the output. It's not aware of what language is being output, as @majodev noted.

Block level: Does whitespace control prevent indentation? It seems to me that it should and if it does not then it's a bug that we should fix. If someone could confirm this for me that would be awesome as I am swamped with the day job.

Complier config option: It would not be too hard to implement such a behavior, simply adding an options check to utilize or omit indent's value here. My only concern here is that with each flag that we introduce at the global level the rendering behavior becomes far less predictable IMO, but I also am not using a large mass of nested partials in my own projects so I could see how this issue could compound on itself.

joshterrell805 · 2014-10-30T15:10:47Z

The indentation is a problem in pre formated blocks. To put a bandaid on this problem, I've been including all helpers at the 0 indent column (no matter what the parent block of the line is).

As you can imagine this looks terrible and breaks readability.

Does anyone have any other ideas except the two ideas recommended thus far? (compiler flag and special syntax)

majodev · 2014-10-30T15:15:39Z

@joshterrell805 nope, I've done the same within my metalsmith pipeline (compiled Markdown content gets inserted into a HTML unescaped handlebars expression), looks awful, but works.

ErisDS · 2014-10-30T15:58:35Z

We are in a position where every single change made or not to the language will piss someone off.

@kpdecker I get it, honestly I do, you literally cannot please everyone! Clearly though, someone made a case strongly enough to get this changed, so there's always the possibility there's an equal and opposite case to change it back that hasn't been heard yet ;)

What I'm trying to get across is that there's a big difference between an aesthetic and a functional change, and it seems like this change was possibly made without the functional ramifications being clear?

Handlebars is agnostic to the output. It's not aware of what language is being output, as @majodev noted.

Handlebars might be output agnostic, but it is frequently used to output languages for which whitespace has meaning, and so changing how whitespace is output is never going to be 100% safe.

Anyway - to continue the discussion towards at the very least having a compiler flag, I believe that handlebars is commonly used in situations where it cannot be expected that the person writing templates has this sort of fine-grained understanding of what an indent could do further down the partial stack. This introduces subtle issues which are hard to diagnose and therefore I'm very much in favour of at least having an option to switch it off. Pretty please 🍰

joshterrell805 · 2014-10-30T16:39:44Z

It's clear that this is a functional problem that needs to be addressed.

I think many of us would be willing to create a pull to fix this issue, but which solution should be implemented? compiler flag? special include syntax? other? all?

shenanigans · 2014-10-30T18:14:18Z

@joshterrell805 I eventually took my helpers off the first column and put their preformatted sections in tags without newlines. <pre>{{{markdown}}}</pre>. Then I slapped myself in the face real hard.

joshterrell805 · 2014-10-30T19:01:00Z

Then I slapped myself in the face real hard.

lol!
There's plenty of situations where the pre tags need to be in the helpers, though.

shenanigans · 2014-10-30T19:17:07Z

They are in the ~~helpers~~ partials. The ~~helper's~~ partial's position may cause the pre-tag itself to be indented unreliably, but as long as the tag contents are correct it will render properly. The contents of the replacement are not given extra indentation so you only need to avoid adding any extraneous newlines and voila.

actual helpers are fine with triplestache. <pre>{{{markdown docStr}}}</pre> but I believe not fine with doublestache.

joshterrell805 · 2014-10-31T17:30:49Z

Thanks for the correction; I meant partial too, not helper.

The contents of the replacement are not given extra indentation so you only need to avoid adding any extraneous newlines and voila.

What qualifies as extraneous newlines? In the method you mentioned above (<pre>{{{markdown docStr}}}</pre>), can docStr contain newlines and retain indentation specified in docStr only? From my experimentation this was not the case...all newlines in docStr get indented by whatever the indentation of the pre block is.

If docStr can contain newlines and retain the specified indentation (not inheriting the indentation of the pre-block), this is a valid solution to the problem, and I don't think any new code needs to be written.

shenanigans · 2014-10-31T18:17:22Z

docStr can contain newlines without tripping indentation behavior as long as the replacement is triplestache, not double. Technically, in the example you're worried about the return value of markdown, not the contents of docStr but same thing. If you need to escape html but you still need to avoid indentation, use a helper and call Handlebars.Utils.escapeExpression.

In my current project, I use the exact line <div class="markdown">{{{markdown docStr}}}</div> with markdown often returning a <pre> as part of its output.

joshterrell805 · 2014-10-31T19:38:39Z

docStr can contain newlines without tripping indentation behavior as long as the replacement is triplestache, not double.
...In my current project, I use the exact line ...

This solves my problem. I'll try this out the next time I'm working on display code.
Thanks so much @shenanigans!

Verifies the behaviors discussed in #858

kpdecker · 2014-11-02T18:21:43Z

I've added a test that confirmed the correct behavior when using whitespace control and partials. I've also added a preventIndent option to the compiler that when enabled will not cause indents when rendering any partial.

ericlowry · 2014-12-04T03:00:31Z

Sorry if this is obvious - but how do I enable preventIndent ? I am using express-handlebars and I want to set the option for all partials... there must be a way. This is super frustrating.

kpdecker · 2014-12-05T04:59:59Z

@ericlowry this is a compiler option. I'm not sure how those are set when using express-handlebars. I would consult their documentation or the project owners.

ericlowry · 2014-12-05T14:37:22Z

Thanks, I guess I was hoping that someone would have encountered this and had a ready solution.

I have an reference to the actual handlebars instance used inside of handlebars express. Is there a way to override the default compiler options? I figure I must be missing something obvious...

handlebars.compiler.options.preventIndent = true; // <-- something like this?

kpdecker · 2014-12-05T16:18:40Z

You need to find the point where the compile or preform oiler call is made.
It's an argument to that.
On Fri, Dec 5, 2014 at 8:37 AM Eric Lowry notifications@github.com wrote:

Thanks, I guess I was hoping that someone would have encountered this and
had a ready solution.

I have an reference to the actual handlebars instance used inside of
handlebars express. Is there a way to override the default compiler
options? I figure I must be missing something obvious...

handlebars.compiler.options.preventIndent = true; // <-- something like
this?

—
Reply to this email directly or view it on GitHub
#858 (comment)
.

mgartner · 2014-12-21T04:48:25Z

@kpdecker why hasn't a 2.0.x patch been released with the new preventIndent option? The only option is bleeding edge or downgrading to 1.3.0 where this isn't an issue.

ericlowry · 2014-12-21T18:24:53Z

I agree completely... release the patch already.

Eric Lowry
eric@myrealms.org
http://ericmlowry.com
(801) 747-9758

On Sat, Dec 20, 2014 at 9:48 PM, Marcus Gartner notifications@github.com
wrote:

@kpdecker https://github.com/kpdecker why hasn't a 2.0.x patch been
released with the new preventIndent option? The only option is bleeding
edge or 1.3.0 it seems like.

—
Reply to this email directly or view it on GitHub
#858 (comment)
.

kpdecker · 2014-12-21T18:39:10Z

This is targeted for the 3.0 release as noted by the milestone attached to this bug. There are too many changes on the tree right now to release anything on the 2.x codeline, at least not without significant time input that I don't have right now. I hope to have 3.0 out soonish, but the job that pays me as well as family obligations are superseding that right now.

Ref handlebars-lang/handlebars.js#858

@kpdecker

Update handlebars from 1.0.0-rc.4 to 3.0.0 ## v3.0.0 - February 10th, 2015 - [#941](handlebars-lang/handlebars.js#941) - Add support for dynamic partial names ([@kpdecker](https://api.github.com/users/kpdecker)) - [#940](handlebars-lang/handlebars.js#940) - Add missing reserved words so compiler knows to use array syntax: ([@mattflaschen](https://api.github.com/users/mattflaschen)) - [#938](handlebars-lang/handlebars.js#938) - Fix example using #with helper ([@diwo](https://api.github.com/users/diwo)) - [#930](handlebars-lang/handlebars.js#930) - Add parent tracking and mutation to AST visitors ([@kpdecker](https://api.github.com/users/kpdecker)) - [#926](handlebars-lang/handlebars.js#926) - Depthed lookups fail when program duplicator runs ([@kpdecker](https://api.github.com/users/kpdecker)) - [#918](handlebars-lang/handlebars.js#918) - Add instructions for 'spec/mustache' to CONTRIBUTING.md, fix a few typos ([@oneeman](https://api.github.com/users/oneeman)) - [#915](handlebars-lang/handlebars.js#915) - Ast update ([@kpdecker](https://api.github.com/users/kpdecker)) - [#910](handlebars-lang/handlebars.js#910) - Different behavior of {{@last}} when {{#each}} in {{#each}} ([@zordius](https://api.github.com/users/zordius)) - [#907](handlebars-lang/handlebars.js#907) - Implement named helper variable references ([@kpdecker](https://api.github.com/users/kpdecker)) - [#906](handlebars-lang/handlebars.js#906) - Add parser support for block params ([@mmun](https://api.github.com/users/mmun)) - [#903](handlebars-lang/handlebars.js#903) - Only provide aliases for multiple use calls ([@kpdecker](https://api.github.com/users/kpdecker)) - [#902](handlebars-lang/handlebars.js#902) - Generate Source Maps ([@kpdecker](https://api.github.com/users/kpdecker)) - [#901](handlebars-lang/handlebars.js#901) - Still escapes with noEscape enabled on isolated Handlebars environment ([@zedknight](https://api.github.com/users/zedknight)) - [#896](handlebars-lang/handlebars.js#896) - Simplify BlockNode by removing intermediate MustacheNode ([@mmun](https://api.github.com/users/mmun)) - [#892](handlebars-lang/handlebars.js#892) - Implement parser for else chaining of helpers ([@kpdecker](https://api.github.com/users/kpdecker)) - [#889](handlebars-lang/handlebars.js#889) - Consider extensible parser API ([@kpdecker](https://api.github.com/users/kpdecker)) - [#887](handlebars-lang/handlebars.js#887) - Handlebars.noConflict() option? ([@bradvogel](https://api.github.com/users/bradvogel)) - [#886](handlebars-lang/handlebars.js#886) - Add SafeString to context (or use duck-typing) ([@dominicbarnes](https://api.github.com/users/dominicbarnes)) - [#870](handlebars-lang/handlebars.js#870) - Registering undefined partial throws exception. ([@max-b](https://api.github.com/users/max-b)) - [#866](handlebars-lang/handlebars.js#866) - comments don't respect whitespace control ([@75lb](https://api.github.com/users/75lb)) - [#863](handlebars-lang/handlebars.js#863) - + jsDelivr CDN info ([@tomByrer](https://api.github.com/users/tomByrer)) - [#858](handlebars-lang/handlebars.js#858) - Disable new default auto-indent at included partials ([@majodev](https://api.github.com/users/majodev)) - [#856](handlebars-lang/handlebars.js#856) - jspm compatibility ([@MajorBreakfast](https://api.github.com/users/MajorBreakfast)) - [#805](handlebars-lang/handlebars.js#805) - Request: "strict" lookups ([@nzakas](https://api.github.com/users/nzakas)) - Export the default object for handlebars/runtime - 5594416 - Lookup partials when undefined - 617dd57 Compatibility notes: - Runtime breaking changes. Must match 3.x runtime and precompiler. - The AST has been upgraded to a public API. - There are a number of changes to this, but the format is now documented in docs/compiler-api.md - The Visitor API has been expanded to support mutation and provide a base implementation - The `JavaScriptCompiler` APIs have been formalized and documented. As part of the sourcemap handling these should be updated to return arrays for concatenation. - `JavaScriptCompiler.namespace` has been removed as it was unused. - `SafeString` is now duck typed on `toHTML` New Features: - noConflict - Source Maps - Block Params - Strict Mode - @last and other each changes - Chained else blocks - @DaTa methods can now have helper parameters passed to them - Dynamic partials [Commits](handlebars-lang/handlebars.js@v2.0.0...v3.0.0) ## v2.0.0 - September 1st, 2014 - Update jsfiddle to 2.0.0-beta.1 - 0670f65 - Add contrib note regarding handlebarsjs.com docs - 4d17e3c - Play nice with gemspec version numbers - 64d5481 [Commits](handlebars-lang/handlebars.js@v2.0.0-beta.1...v2.0.0) ## v2.0.0-beta.1 - August 26th, 2014 - [#787](handlebars-lang/handlebars.js#787) - Remove whitespace surrounding standalone statements ([@kpdecker](https://api.github.com/users/kpdecker)) - [#827](handlebars-lang/handlebars.js#827) - Render false literal as “false” ([@scoot557](https://api.github.com/users/scoot557)) - [#767](handlebars-lang/handlebars.js#767) - Subexpressions bug with hash and context ([@evensoul](https://api.github.com/users/evensoul)) - Changes to 0/undefined handling - [#731](handlebars-lang/handlebars.js#731) - Strange behavior for {{#foo}} {{bar}} {{/foo}} when foo is 0 ([@kpdecker](https://api.github.com/users/kpdecker)) - [#820](handlebars-lang/handlebars.js#820) - strange behavior for {{foo.bar}} when foo is 0 or null or false ([@zordius](https://api.github.com/users/zordius)) - [#837](handlebars-lang/handlebars.js#837) - Strange input for custom helper ( foo.bar == false when foo is undefined ) ([@zordius](https://api.github.com/users/zordius)) - [#819](handlebars-lang/handlebars.js#819) - Implement recursive field lookup ([@kpdecker](https://api.github.com/users/kpdecker)) - [#764](handlebars-lang/handlebars.js#764) - This reference not working for helpers ([@kpdecker](https://api.github.com/users/kpdecker)) - [#773](handlebars-lang/handlebars.js#773) - Implicit parameters in {{#each}} introduces a peculiarity in helpers calling convention ([@Bertrand](https://api.github.com/users/Bertrand)) - [#783](handlebars-lang/handlebars.js#783) - helperMissing and consistency for different expression types ([@ErisDS](https://api.github.com/users/ErisDS)) - [#795](handlebars-lang/handlebars.js#795) - Turn the precompile script into a wrapper around a module. ([@jwietelmann](https://api.github.com/users/jwietelmann)) - [#823](handlebars-lang/handlebars.js#823) - Support inverse sections on the with helper ([@dan-manges](https://api.github.com/users/dan-manges)) - [#834](handlebars-lang/handlebars.js#834) - Refactor blocks, programs and inverses ([@mmun](https://api.github.com/users/mmun)) - [#852](handlebars-lang/handlebars.js#852) - {{foo~}} space control behavior is different from older version ([@zordius](https://api.github.com/users/zordius)) - [#835](handlebars-lang/handlebars.js#835) - Templates overwritten if file is loaded twice - Expose escapeExpression on the root object - 980c38c - Remove nested function eval in blockHelperMissing - 6f22ec1 - Fix compiler program de-duping - 9e3f824 Compatibility notes: - The default build now outputs a generic UMD wrapper. This should be transparent change but may cause issues in some environments. - Runtime compatibility breaks in both directions. Ensure that both compiler and client are upgraded to 2.0.0-beta.1 or higher at the same time. - `programWithDepth` has been removed an instead an array of context values is passed to fields needing depth lookups. - `false` values are now printed to output rather than silently dropped - Lines containing only block statements and whitespace are now removed. This matches the Mustache spec but may cause issues with code that expects whitespace to exist but would not otherwise. - Partials that are standalone will now indent their rendered content - `AST.ProgramNode`'s signature has changed. - Numerious methods/features removed from psuedo-API classes - `JavaScriptCompiler.register` - `JavaScriptCompiler.replaceStack` no longer supports non-inline replace - `Compiler.disassemble` - `DECLARE` opcode - `strip` opcode - `lookup` opcode - Content nodes may have their `string` values mutated over time. `original` field provides the unmodified value. - Removed unused `Handlebars.registerHelper` `inverse` parameter - `each` helper requires iterator parameter [Commits](handlebars-lang/handlebars.js@v2.0.0-alpha.4...v2.0.0-beta.1) ## v2.0.0-alpha.4 - May 19th, 2014 - Expose setup wrappers for compiled templates - 3638874 [Commits](handlebars-lang/handlebars.js@v2.0.0-alpha.3...v2.0.0-alpha.4) ## v2.0.0-alpha.3 - May 19th, 2014 - [#797](handlebars-lang/handlebars.js#797) - Pass full helper ID to helperMissing when options are provided ([@tomdale](https://api.github.com/users/tomdale)) - [#793](handlebars-lang/handlebars.js#793) - Ensure isHelper is coerced to a boolean ([@mmun](https://api.github.com/users/mmun)) - Refactor template init logic - 085e5e1 [Commits](handlebars-lang/handlebars.js@v2.0.0-alpha.2...v2.0.0-alpha.3) ## v2.0.0-alpha.2 - March 6th, 2014 - [#756](handlebars-lang/handlebars.js#756) - fix bug in IE<=8 (no Array::map), closes #751 ([@jenseng](https://api.github.com/users/jenseng)) - [#749](handlebars-lang/handlebars.js#749) - properly handle multiple subexpressions in the same hash, fixes #748 ([@jenseng](https://api.github.com/users/jenseng)) - [#743](handlebars-lang/handlebars.js#743) - subexpression confusion/problem? ([@waynedpj](https://api.github.com/users/waynedpj)) - [#746](handlebars-lang/handlebars.js#746) - [CLI] support `handlebars --version` ([@apfelbox](https://api.github.com/users/apfelbox)) - [#747](handlebars-lang/handlebars.js#747) - updated grunt-saucelabs, failing tests revealed ([@Jonahss](https://api.github.com/users/Jonahss)) - Make JSON a requirement for the compiler. - 058c0fb - Temporarily kill the AWS publish CI step - 8347ee2 Compatibility notes: - A JSON polyfill is required to run the compiler under IE8 and below. It's recommended that the precompiler be used in lieu of running the compiler on these legacy environments. [Commits](handlebars-lang/handlebars.js@v2.0.0-alpha.1...v2.0.0-alpha.2) ## v2.0.0-alpha.1 - February 10th, 2014 - [#182](handlebars-lang/handlebars.js#182) - Allow passing hash parameters to partials ([@kpdecker](https://api.github.com/users/kpdecker)) - [#392](handlebars-lang/handlebars.js#392) - Access to root context in partials and helpers ([@kpdecker](https://api.github.com/users/kpdecker)) - [#472](handlebars-lang/handlebars.js#472) - Helpers cannot have decimal parameters ([@kayleg](https://api.github.com/users/kayleg)) - [#569](handlebars-lang/handlebars.js#569) - Unable to lookup array values using @Index ([@kpdecker](https://api.github.com/users/kpdecker)) - [#491](handlebars-lang/handlebars.js#491) - For nested helpers: get the @ variables of the outer helper from the inner one ([@kpdecker](https://api.github.com/users/kpdecker)) - [#669](handlebars-lang/handlebars.js#669) - Ability to unregister a helper ([@dbachrach](https://api.github.com/users/dbachrach)) - [#730](handlebars-lang/handlebars.js#730) - Raw block helpers ([@kpdecker](https://api.github.com/users/kpdecker)) - [#634](handlebars-lang/handlebars.js#634) - It would be great to have the helper name passed to `blockHelperMissing` ([@kpdecker](https://api.github.com/users/kpdecker)) - [#729](handlebars-lang/handlebars.js#729) - Convert template spec to object literal ([@kpdecker](https://api.github.com/users/kpdecker)) - [#658](handlebars-lang/handlebars.js#658) - Depthed helpers do not work after an upgrade from 1.0.0 ([@xibxor](https://api.github.com/users/xibxor)) - [#671](handlebars-lang/handlebars.js#671) - Crashes on no-parameter {{#each}} ([@stepancheg](https://api.github.com/users/stepancheg)) - [#689](handlebars-lang/handlebars.js#689) - broken template precompilation ([@AAS](https://api.github.com/users/AAS)) - [#698](handlebars-lang/handlebars.js#698) - Fix parser generation under windows ([@osiris43](https://api.github.com/users/osiris43)) - [#699](handlebars-lang/handlebars.js#699) - @DaTa not compiles to invalid JS in stringParams mode ([@kpdecker](https://api.github.com/users/kpdecker)) - [#705](handlebars-lang/handlebars.js#705) - 1.3.0 can not be wrapped in an IIFE ([@craigteegarden](https://api.github.com/users/craigteegarden)) - [#706](handlebars-lang/handlebars.js#706) - README: Use with helper instead of relying on blockHelperMissing ([@scottgonzalez](https://api.github.com/users/scottgonzalez)) - [#700](handlebars-lang/handlebars.js#700) - Remove redundant conditions ([@blakeembrey](https://api.github.com/users/blakeembrey)) - [#704](handlebars-lang/handlebars.js#704) - JavaScript Compiler Cleanup ([@blakeembrey](https://api.github.com/users/blakeembrey)) Compatibility notes: - `helperMissing` helper no longer has the indexed name argument. Helper name is now available via `options.name`. - Precompiler output has changed, which breaks compatibility with prior versions of the runtime and precompiled output. - `JavaScriptCompiler.compilerInfo` now returns generic objects rather than javascript source. - AST changes - INTEGER -> NUMBER - Additional PartialNode hash parameter - New RawBlockNode type - Data frames now have a `_parent` field. This is internal but is enumerable for performance/compatability reasons. [Commits](handlebars-lang/handlebars.js@v1.3.0...v2.0.0-alpha.1) ## v1.3.0 - January 1st, 2014 - [#690](handlebars-lang/handlebars.js#690) - Added support for subexpressions ([@machty](https://api.github.com/users/machty)) - [#696](handlebars-lang/handlebars.js#696) - Fix for reserved keyword "default" ([@nateirwin](https://api.github.com/users/nateirwin)) - [#692](handlebars-lang/handlebars.js#692) - add line numbers to nodes when parsing ([@fivetanley](https://api.github.com/users/fivetanley)) - [#695](handlebars-lang/handlebars.js#695) - Pull options out from param setup to allow easier extension ([@blakeembrey](https://api.github.com/users/blakeembrey)) - [#694](handlebars-lang/handlebars.js#694) - Make the environment reusable ([@blakeembrey](https://api.github.com/users/blakeembrey)) - [#636](handlebars-lang/handlebars.js#636) - Print line and column of errors ([@sgronblo](https://api.github.com/users/sgronblo)) - Use literal for data lookup - c1a93d3 - Add stack handling sanity checks - cd885bf - Fix stack id "leak" on replaceStack - ddfe457 - Fix incorrect stack pop when replacing literals - f4d337d [Commits](handlebars-lang/handlebars.js@v1.2.1...v1.3.0) ## v1.2.1 - December 26th, 2013 - [#684](handlebars-lang/handlebars.js#684) - Allow any number of trailing characters for valid JavaScript variable ([@blakeembrey](https://api.github.com/users/blakeembrey)) - [#686](handlebars-lang/handlebars.js#686) - Falsy AMD module names in version 1.2.0 ([@kpdecker](https://api.github.com/users/kpdecker)) [Commits](handlebars-lang/handlebars.js@v1.2.0...v1.2.1) ## v1.2.0 - December 23rd, 2013 - [#675](handlebars-lang/handlebars.js#675) - Cannot compile empty template for partial ([@erwinw](https://api.github.com/users/erwinw)) - [#677](handlebars-lang/handlebars.js#677) - Triple brace statements fail under IE ([@hamzacm](https://api.github.com/users/hamzaCM)) - [#655](handlebars-lang/handlebars.js#655) - Loading Handlebars using bower ([@niki4810](https://api.github.com/users/niki4810)) - [#657](handlebars-lang/handlebars.js#657) - Fixes issue where cli compiles non handlebars templates ([@chrishoage](https://api.github.com/users/chrishoage)) - [#681](handlebars-lang/handlebars.js#681) - Adds in-browser testing and Saucelabs CI ([@kpdecker](https://api.github.com/users/kpdecker)) - [#661](handlebars-lang/handlebars.js#661) - Add @FIRST and @Index to #each object iteration ([@cgp](https://api.github.com/users/cgp)) - [#650](handlebars-lang/handlebars.js#650) - Handlebars is MIT-licensed ([@thomasboyt](https://api.github.com/users/thomasboyt)) - [#641](handlebars-lang/handlebars.js#641) - Document ember testing process ([@kpdecker](https://api.github.com/users/kpdecker)) - [#662](handlebars-lang/handlebars.js#662) - handlebars-source 1.1.2 is missing from RubyGems. - [#656](handlebars-lang/handlebars.js#656) - Expose COMPILER_REVISION checks as a hook ([@machty](https://api.github.com/users/machty)) - [#668](handlebars-lang/handlebars.js#668) - Consider publishing handlebars-runtime as a separate module on npm ([@dlmanning](https://api.github.com/users/dlmanning)) - [#679](handlebars-lang/handlebars.js#679) - Unable to override invokePartial ([@mattbrailsford](https://api.github.com/users/mattbrailsford)) - [#646](handlebars-lang/handlebars.js#646) - Fix "\\{{" immediately following "\{{" ([@dmarcotte](https://api.github.com/users/dmarcotte)) - Allow extend to work with non-prototyped objects - eb53f2e - Add JavascriptCompiler public API tests - 1a751b2 - Add AST test coverage for more complex paths - ddea5be - Fix handling of boolean escape in MustacheNode - b4968bb Compatibility notes: - `@index` and `@first` are now supported for `each` iteration on objects - `Handlebars.VM.checkRevision` and `Handlebars.JavaScriptCompiler.prototype.compilerInfo` now available to modify the version checking behavior. - Browserify users may link to the runtime library via `require('handlebars/runtime')` [Commits](handlebars-lang/handlebars.js@v1.1.2...v1.2.0) ## v1.1.2 - November 5th, 2013 - [#645](handlebars-lang/handlebars.js#645) - 1.1.1 fails under IE8 ([@kpdecker](https://api.github.com/users/kpdecker)) - [#644](handlebars-lang/handlebars.js#644) - Using precompiled templates (AMD mode) with handlebars.runtime 1.1.1 ([@fddima](https://api.github.com/users/fddima)) - Add simple binary utility tests - 96a45a4 - Fix empty string compilation - eea708a [Commits](handlebars-lang/handlebars.js@v1.1.1...v1.1.2) ## v1.1.1 - November 4th, 2013 - [#642](handlebars-lang/handlebars.js#642) - handlebars 1.1.0 are broken with nodejs - Fix release notes link - 17ba258 [Commits](handlebars-lang/handlebars.js@v1.1.0...v1.1.1) ## v1.1.0 - November 3rd, 2013 - [#628](handlebars-lang/handlebars.js#628) - Convert code to ES6 modules ([@kpdecker](https://api.github.com/users/kpdecker)) - [#336](handlebars-lang/handlebars.js#336) - Add whitespace control syntax ([@kpdecker](https://api.github.com/users/kpdecker)) - [#535](handlebars-lang/handlebars.js#535) - Fix for probable JIT error under Safari ([@sorentwo](https://api.github.com/users/sorentwo)) - [#483](handlebars-lang/handlebars.js#483) - Add first and last @ vars to each helper ([@denniskuczynski](https://api.github.com/users/denniskuczynski)) - [#557](handlebars-lang/handlebars.js#557) - `\\{{foo}}` escaping only works in some situations ([@dmarcotte](https://api.github.com/users/dmarcotte)) - [#552](handlebars-lang/handlebars.js#552) - Added BOM removal flag. ([@blessenm](https://api.github.com/users/blessenm)) - [#543](handlebars-lang/handlebars.js#543) - publish passing master builds to s3 ([@fivetanley](https://api.github.com/users/fivetanley)) - [#608](handlebars-lang/handlebars.js#608) - Add `includeZero` flag to `if` conditional - [#498](handlebars-lang/handlebars.js#498) - `Handlebars.compile` fails on empty string although a single blank works fine - [#599](handlebars-lang/handlebars.js#599) - lambda helpers only receive options if used with arguments - [#592](handlebars-lang/handlebars.js#592) - Optimize array and subprogram performance - [#571](handlebars-lang/handlebars.js#571) - uglify upgrade breaks compatibility with older versions of node - [#587](handlebars-lang/handlebars.js#587) - Partial inside partial breaks? Compatibility notes: - The project now includes separate artifacts for AMD, CommonJS, and global objects. - AMD: Users may load the bundled `handlebars.amd.js` or `handlebars.runtime.amd.js` files or load individual modules directly. AMD users should also note that the handlebars object is exposed via the `default` field on the imported object. This [gist](https://gist.github.com/wycats/7417be0dc361a69d5916) provides some discussion of possible compatibility shims. - CommonJS/Node: Node loading occurs as normal via `require` - Globals: The `handlebars.js` and `handlebars.runtime.js` files should behave in the same manner as the v1.0.12 / 1.0.0 release. - Build artifacts have been removed from the repository. [npm][npm], [components/handlebars.js][components], [cdnjs][cdnjs], or the [builds page][builds-page] should now be used as the source of built artifacts. - Context-stored helpers are now always passed the `options` hash. Previously no-argument helpers did not have this argument. [Commits](handlebars-lang/handlebars.js@v1.0.12...v1.1.0) ## v1.0.12 / 1.0.0 - May 31 2013 - [#515](handlebars-lang/handlebars.js#515) - Add node require extensions support ([@jjclark1982](https://github.com/jjclark1982)) - [#517](handlebars-lang/handlebars.js#517) - Fix amd precompiler output with directories ([@blessenm](https://github.com/blessenm)) - [#433](handlebars-lang/handlebars.js#433) - Add support for unicode ids - [#469](handlebars-lang/handlebars.js#469) - Add support for `?` in ids - [#534](handlebars-lang/handlebars.js#534) - Protect from object prototype modifications - [#519](handlebars-lang/handlebars.js#519) - Fix partials with . name ([@jamesgorrie](https://github.com/jamesgorrie)) - [#519](handlebars-lang/handlebars.js#519) - Allow ID or strings in partial names - [#437](handlebars-lang/handlebars.js#437) - Require matching brace counts in escaped expressions - Merge passed partials and helpers with global namespace values - Add support for complex ids in @DaTa references - Docs updates Compatibility notes: - The parser is now stricter on `{{{`, requiring that the end token be `}}}`. Templates that do not follow this convention should add the additional brace value. - Code that relies on global the namespace being muted when custom helpers or partials are passed will need to explicitly pass an `undefined` value for any helpers that should not be available. - The compiler version has changed. Precompiled templates with 1.0.12 or higher must use the 1.0.0 or higher runtime. [Commits](handlebars-lang/handlebars.js@v1.0.11...v1.0.12) ## v1.0.11 / 1.0.0-rc4 - May 13 2013 - [#458](handlebars-lang/handlebars.js#458) - Fix `./foo` syntax ([@jpfiset](https://github.com/jpfiset)) - [#460](handlebars-lang/handlebars.js#460) - Allow `:` in unescaped identifers ([@jpfiset](https://github.com/jpfiset)) - [#471](handlebars-lang/handlebars.js#471) - Create release notes (These!) - [#456](handlebars-lang/handlebars.js#456) - Allow escaping of `\\` - [#211](handlebars-lang/handlebars.js#211) - Fix exception in `escapeExpression` - [#375](handlebars-lang/handlebars.js#375) - Escape unicode newlines - [#461](handlebars-lang/handlebars.js#461) - Do not fail when compiling `""` - [#302](handlebars-lang/handlebars.js#302) - Fix sanity check in knownHelpersOnly mode - [#369](handlebars-lang/handlebars.js#369) - Allow registration of multiple helpers and partial by passing definition object - Add bower package declaration ([@DevinClark](https://github.com/DevinClark)) - Add NuSpec package declaration ([@MikeMayer](https://github.com/MikeMayer)) - Handle empty context in `with` ([@thejohnfreeman](https://github.com/thejohnfreeman)) - Support custom template extensions in CLI ([@matteoagosti](https://github.com/matteoagosti)) - Fix Rhino support ([@broady](https://github.com/broady)) - Include contexts in string mode ([@leshill](https://github.com/leshill)) - Return precompiled scripts when compiling to AMD ([@JamesMaroney](https://github.com/JamesMaroney)) - Docs updates ([@iangreenleaf](https://github.com/iangreenleaf), [@gilesbowkett](https://github.com/gilesbowkett), [@utkarsh2012](https://github.com/utkarsh2012)) - Fix `toString` handling under IE and browserify ([@tommydudebreaux](https://github.com/tommydudebreaux)) - Add program metadata

lzilioli · 2015-06-24T16:00:39Z

This same behavior appears to exist when calling partials, or outputting content with the {{{ }}} syntax (as described by @joshterrell805). Is there a way to prevent this behavior in these cases as well?

kpdecker · 2015-06-26T03:09:45Z

@lzilioli please open a new issue with supporting fiddle or other repo case if you're running into issues. I'm not sure what you mean by the same behavior as there are a few things discussed here, quite awhile ago, and it's probably better to start a new standalone conversation if you have concerns.

…ang/handlebars.js#858)

…eak. handlebars-lang/handlebars.js#858

…use it is incredibly counter-intuitive

kpdecker added feature labels Sep 4, 2014

ErisDS mentioned this issue Oct 30, 2014

Indenting partials causes unexpected results nitinthewiz/ghost-phantom#14

Closed

ErisDS mentioned this issue Oct 30, 2014

Auto-indent of partials causes problems with rendering code blocks in blog posts TryGhost/Ghost#4364

Closed

kpdecker added a commit that referenced this issue Nov 2, 2014

Add test for whitespace control w/ partial indent

7c220b9

Verifies the behaviors discussed in #858

kpdecker removed the unverified label Nov 2, 2014

kpdecker added this to the 2.1 milestone Nov 2, 2014

kpdecker closed this as completed in 632fadc Nov 2, 2014

NateEag mentioned this issue Jan 22, 2015

Fixes indents of templates and bumps YUI dependencies yui/yuidoc#292

Merged

desandro added a commit to metafizzy/flickity-docs that referenced this issue Jan 29, 2015

no leading whitespace for {{> body}}

268d6d2

Ref handlebars-lang/handlebars.js#858

kkirsche mentioned this issue Feb 10, 2015

Update handlebars from 1.0.0-rc.4 to 3.0.0 rubyloco/rubyloco.com#16

Merged

nknapp mentioned this issue Mar 9, 2015

Document "preventIndent" option wycats/handlebars-site#98

Merged

harttle mentioned this issue Mar 11, 2015

Can I add options for handlebars compiler? TryGhost/express-hbs#73

Closed

zachthompson mentioned this issue Jun 30, 2015

MLB Boxscore - Whitespace Fix duckduckgo/zeroclickinfo-spice#1972

Merged

svbergerem mentioned this issue Jul 27, 2015

Tabulation seems to be inserted after each line break in code blocks of a reshare in stream. diaspora/diaspora#6253

Closed

royriojas pushed a commit to royriojas/yuidoc-theme-blue that referenced this issue Sep 8, 2015

FIX: issue introduced by handlebars [autoindent feature](handlebars-l…

f7f8674

…ang/handlebars.js#858)

irisli added a commit to stellar-deprecated/developers that referenced this issue Sep 29, 2015

remove autoindentation from handlebars that caused indentations to br…

5c4f030

…eak. handlebars-lang/handlebars.js#858

taylorhughes referenced this issue in taylorhughes/skit Jan 6, 2016

Update to Handlebars v4.0 and disable implicit partial indenting beca…

ba9e292

…use it is incredibly counter-intuitive

rfunduk mentioned this issue Apr 28, 2016

Support preventIndent option pcardune/handlebars-loader#93

Merged

tajo mentioned this issue Jun 5, 2016

Prevent handlebars auto indenting cloudflarearchive/json-schema-docs-generator#20

Merged

ghost mentioned this issue Apr 11, 2017

Support the preventIndent Handlebars option foundation/panini#113

Closed

bdiz mentioned this issue Mar 30, 2019

Prevents indent on blank lines of partials. #1518

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable new default auto-indent at included partials #858

Disable new default auto-indent at included partials #858

majodev commented Sep 3, 2014

kpdecker commented Sep 4, 2014

majodev commented Sep 5, 2014

joshterrell805 commented Sep 6, 2014

kevinrenskers commented Sep 11, 2014

75lb commented Sep 20, 2014

shenanigans commented Sep 28, 2014

ErisDS commented Oct 30, 2014

majodev commented Oct 30, 2014

ErisDS commented Oct 30, 2014

ErisDS commented Oct 30, 2014

ErisDS commented Oct 30, 2014

kpdecker commented Oct 30, 2014

joshterrell805 commented Oct 30, 2014

majodev commented Oct 30, 2014

ErisDS commented Oct 30, 2014

joshterrell805 commented Oct 30, 2014

shenanigans commented Oct 30, 2014

joshterrell805 commented Oct 30, 2014

shenanigans commented Oct 30, 2014

joshterrell805 commented Oct 31, 2014

shenanigans commented Oct 31, 2014

joshterrell805 commented Oct 31, 2014

kpdecker commented Nov 2, 2014

ericlowry commented Dec 4, 2014

kpdecker commented Dec 5, 2014

ericlowry commented Dec 5, 2014

kpdecker commented Dec 5, 2014

mgartner commented Dec 21, 2014

ericlowry commented Dec 21, 2014

kpdecker commented Dec 21, 2014

lzilioli commented Jun 24, 2015

kpdecker commented Jun 26, 2015

Disable new default auto-indent at included partials #858

Disable new default auto-indent at included partials #858

Comments

majodev commented Sep 3, 2014

kpdecker commented Sep 4, 2014

majodev commented Sep 5, 2014

joshterrell805 commented Sep 6, 2014

kevinrenskers commented Sep 11, 2014

75lb commented Sep 20, 2014

shenanigans commented Sep 28, 2014

ErisDS commented Oct 30, 2014

majodev commented Oct 30, 2014

ErisDS commented Oct 30, 2014

ErisDS commented Oct 30, 2014

ErisDS commented Oct 30, 2014

kpdecker commented Oct 30, 2014

joshterrell805 commented Oct 30, 2014

majodev commented Oct 30, 2014

ErisDS commented Oct 30, 2014

joshterrell805 commented Oct 30, 2014

shenanigans commented Oct 30, 2014

joshterrell805 commented Oct 30, 2014

shenanigans commented Oct 30, 2014

joshterrell805 commented Oct 31, 2014

shenanigans commented Oct 31, 2014

joshterrell805 commented Oct 31, 2014

kpdecker commented Nov 2, 2014

ericlowry commented Dec 4, 2014

kpdecker commented Dec 5, 2014

ericlowry commented Dec 5, 2014

kpdecker commented Dec 5, 2014

mgartner commented Dec 21, 2014

ericlowry commented Dec 21, 2014

kpdecker commented Dec 21, 2014

lzilioli commented Jun 24, 2015

kpdecker commented Jun 26, 2015