Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded assumptions #45

Closed
joaovieira opened this issue Aug 23, 2018 · 2 comments
Closed

Remove hard-coded assumptions #45

joaovieira opened this issue Aug 23, 2018 · 2 comments

Comments

@joaovieira
Copy link
Contributor

If I wanted to output the generated service worker to any other place (e.g. .next/static or static - so they are automatically statically served) using workboxOpts.swDest then everything else breaks 😬
@hanford
Copy link
Owner

hanford commented Aug 23, 2018

@joaovieira can I close in favor of this issue?

#47

@joaovieira
Copy link
Contributor Author

Yep 👍Will chime in there.

@hanford hanford closed this as completed Aug 23, 2018
@hanford hanford reopened this Aug 23, 2018
hanford added a commit that referenced this issue Sep 17, 2018
@hanford
begin rewriting export functionality to work with next 7
013af97 
refs #23 #45
hanford added a commit that referenced this issue Sep 17, 2018
@hanford
begin rewriting export functionality to work with next 7
8779710 
refs #23 #45
@joaovieira joaovieira mentioned this issue Sep 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaovieira @hanford