Generate manifest from original. Better export. #59
Conversation
|
Woah! You beat me to it 🔥 I had a WIP but wasn't totally happy with it: https://github.com/hanford/next-offline/tree/export-rewrite I'll review this today! |
|
I actually thought about mentioning it. But it really just started with the #49, then I got carried away.. 😆But do let me know if you prefer things in any other way! No rush for the review. I forgot to change the next requirements in package.json. Doing it now. |
|
ahh, @joaovieira will we need to make make the major improvement to the codebase IMO 🍾🍻 |
|
Just did. Yes. That new |
| { | ||
| "printWidth": 100, | ||
| "trailingComma": "all", | ||
| "singleQuote": true |
There was a problem hiding this comment.
put some defaults that I use personally. the only difference I think was the trailingComma option. what do you prefer?
| "prettier": "^1.14.2", | ||
| "pretty-quick": "^1.6.0" | ||
| "prettier": "^1.14.3", | ||
| "pretty-quick": "^1.7.0" |
There was a problem hiding this comment.
remove unused ones and updated all packages
| "workbox-webpack-plugin": "^3.5.0" | ||
| "fs-extra": "~7.0.0", | ||
| "glob": "~7.1.3", | ||
| "webpack": "^4.19.1", |
There was a problem hiding this comment.
still required by workbox plugin even though it's not a peer dependency 😩
|
Thanks again ❤️ |
|
Live in 3.0.0 🔥🎉 |
Luckily the Next 7 builds everything inside
/staticso the previous version just works 🎉This PR refactors the logic as discussed in #49 to read the workbox-generated precache manifest instead of generating one from scratch. This should be more reliable moving forward, in case Next.js updates their paths.
On top of that I've made the export functionality using the new
exportPathMapoptions which simplifies massively. #23Finally, I've removed the hard-coded service-worker.js to use
workboxOpts.swDesteverywhere. #45This is not compatible with next@6 so it requires a major bump.
Fixes #49.
Fixes #23.
Fixes #45.