Use workbox precache manifest output

[joaovieira]

While digging in I found out that workbox-webpack-plugin limits all of the "transform" options to the globPattern files only. I.e. don't run modifyUrlPrefix on webpack-generated assets, for example. See whole explanation here.

I then found out this will be available in workbox-webpack-plugin v4: GoogleChrome/workbox#1591

We can still do all of that work manually:

1. Read contents of precache-manifest.*.js
2. Mimic modifyUrlPrefix according to the existing exportPathMap
3. Remove revision from hashed files (maybe all)
4. Ignore unserved files (e.g. build-manifest.json)

I'd be ok to wait for v4, given the current version is working fine. Reading from the generated precache manifest is just a more accurate process.

[hanford]

Sounds good to me!

[joaovieira]

Moreover, I'm wondering if we should really override the revision with Next's buildId. I believe the revision is the file's content hash. Thus, if the file didn't change between builds we shouldn't set another revision, as the file will already be cached.

[hanford]

Good catch @joaovieira ! I can probably fix that today or this weekend unless you can beat me to it

[joaovieira]

Nope, go ahead. I'll be on hols for the next week 😄

…

On Fri, 24 Aug 2018, 17:27 Jack Hanford, ***@***.***> wrote: Good catch! I can probably fix that today or this weekend unless you can beat me to it — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAc96_X_KOj5uvmztf6ubh-4d29p_wG6ks5uUClmgaJpZM4WLLU5> .