Add support for FilterMaintenanceAccessory

[gjvanderheiden]

#124

Pull Request Checklist

Please confirm that you've done the following when opening a new pull request:

• For fixes and other improvements, please reference the GitHub issue that your change addresses.
• For fixes, optimizations and new features, please add an entry to the CHANGES.md file.
• Run mvn compile before committing, so that the auto-code formatter will format your changes consistently with the rest of the project.

[gjvanderheiden]

linked issue : #123

Had to change the IntegerCharacteristic too. It didn't support unit nor no value. (needed for ResetFilter). Tested it with my own project, which uses this characteristic excessively.

Really missing exciting unit tests here. Unit test could test how the IntegerCharacteristic is responding to this in the json build.

[yfre]

for filter maintenance we need additional characteristics but i could not find them in PR.
e.g.
ResetFilterIndicationCharacteristic
FilterLifeLevelCharacteristic
FilterChangeIndicationCharacteristic

[yfre]

with the new linked service support we dont need to have any dedicated methods on accessory levels but can basically add any service to any accessory, e.g. we can add Fan to Air Purifier
it looks like this (im adding battery service to switch but it works the same for all other accessories and services)

final MockSwitch switch1 = new MockSwitch();
final MockBatteryService batteryService = new MockBatteryService();
switch1.getServices().add(batteryService.getPrimaryService());

means the only thing we need to implement is the FilterMaintanceService

[gjvanderheiden]

for filter maintenance we need additional characteristics but i could not find them in PR.
e.g.
ResetFilterIndicationCharacteristic
FilterLifeLevelCharacteristic
FilterChangeIndicationCharacteristic

buggar. beep**-ed something up with the change lists in my IDE. Thanks for mentioning

[gjvanderheiden]

with the new linked service support we dont need to have any dedicated methods on accessory levels but can basically add any service to any accessory, e.g. we can add Fan to Air Purifier
it looks like this (im adding battery service to switch but it works the same for all other accessories and services)

final MockSwitch switch1 = new MockSwitch();
final MockBatteryService batteryService = new MockBatteryService();
switch1.getServices().add(batteryService.getPrimaryService());

means the only thing we need to implement is the FilterMaintanceService

I like the dynamic possibilities.
I could be missing something, but getServices() returns a new instance of the service with every call. I can't see this working with HomekitBridge.addAccessory().

edit:

also see
HomeKitRegistry.reset():
....
for (Service service : accessory.getServices()) {
newServices.add(service);
newServices.addAll(service.getLinkedServices());
}
...

[gjvanderheiden]

Another alternative would be:

HomekitAccessory accessory = new MockSwitch(...);
accessory.addLinkedAccessory(new MockBatteryAccessory());

[gjvanderheiden]

@yfre thrown the 2 modification out of the window. How to link the services is another issue. Thank you for the review

[gjvanderheiden]

added comment to #104(#104). Can't add the accessory right now.

[yfre]

looks good for me.