[FFM-9925] - Testgrid - % rollout - Ruby SDK - Fix MM3 hash #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update code to ignore 0 weights - Additional debug statements around distribution for easier diagnostics - Remove some Ruby files that shouldn't be checked into source control
erdirowlands
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-9925 - Testgrid - % rollout - Ruby SDK - Fix MM3 hash
What
Various fixes to MM3 hash to bring it in alignment with GoLang SDK
<ATTR>:<VALUE>instead of<VALUE>:<ATTR>Also
Why
Review SDKs to make sure Murmur3 hash calculations are consistent across SDKs and buckets mappings align for customers that rely on this feature.
Testing
New percentage rollout tests added to testgrid, these will be committed later