Skip to content

Conversation

@harrisoncramer
Copy link
Owner

@harrisoncramer harrisoncramer commented Oct 13, 2024

We'll use the internal ID of the Merge Request rather than the source/target branch when a specific MR is chosen, which is guaranteed to be unique and will avoid situations where we pass along a source/target relationship that is not unique. This is unusual but technically still possible if someone is repeatedly opening MRs against a branch (say main) from another branch, merging them and deleting the source branch, then re-creating a new MR with the same branch.

@harrisoncramer harrisoncramer changed the base branch from main to develop October 13, 2024 19:08
@harrisoncramer harrisoncramer marked this pull request as ready for review October 13, 2024 19:09
@harrisoncramer harrisoncramer merged commit a63823c into develop Oct 13, 2024
6 checks passed
harrisoncramer added a commit that referenced this pull request Oct 13, 2024
fix: Error messages and run all tests (#381)
feat: Automatically open fold under cursor (#380)
fix: Discussion ID is not required (#383)
chore: Add more emojis (#384)
fix: Publish all drafts (#391)
fix: Make discussion tree buffers no-modifiable (#394)
fix: Incorrect warning about commits (#395)
fix: Show draft replies in the correct tree (#396)
fix: Cannot choose merge requests (#398)

---------

Co-authored-by: George Kontridze <george.kontridze@gmail.com>
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants