Feat: Improve popup UX #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @harrisoncramer, I realize that there're many changes in this PR so I will really appreciate if you find the time to review and merge it. I probably should have split it into separate PRs, and I can still do this if you'd prefer. But at the same time, I've really taken care to make individual commits meaningful which should simplify review. |
jakubbortlik
commented
Nov 19, 2024
|
This is a big improvement, thanks for making these changes. I've left some comments. |
Thanks for the review. I'll implement your suggestions and mark the PR for another review. |
Pipeline and help popups are only customizable through the general `settings.popup` field.
The `description_popup` state is created with `u.create_popup_state` instead of `u.create_box_popup_state` because otherwise the resizing doesn't work for some reason.
The `description_popup` state is created with `u.create_popup_state` instead of `u.create_box_popup_state` because otherwise the resizing doesn't work for some reason.
This makes sure it's shown on top of the pipeline popup.
This makes it possible to place the popup in the bottom right corner where it doesn't obscure the content of the reviewer.
jakubbortlik
force-pushed
the
fix-re-enable-popup-configuration
branch
from
a40b7ed to
82f509d
Compare
harrisoncramer
approved these changes
Dec 6, 2024
harrisoncramer
added a commit
that referenced
this pull request
Dec 11, 2024
* Feat: Enable sorting discussions by original comment (#422) * Feat: Improve popup UX (#426) * Feat: Automatically update MR summary details (#427) * Feat: Show update progress in winbar (#432) * Feat: Abbreviate winbar (#439) * Fix: Note Creation Bug (#441) * Fix: Checking whether comment can be created (#434) * Fix: Syntax in discussion tree (#433) * fix: improve indication of resolved threads and drafts (#442) * Docs: Various minor improvements (#445) --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve user experience with popups in
gitlab.nvimin several ways:draftfield)