Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to error handling when capturing URLs, both single link and batch.
Single link errors are shown closer to the form, smaller, read by screen readers, and tweaked handling for a couple of messages:
I also looked at error handling for the batch capture modal and found that its error handling was pretty clunky -- if you don't put in urls, it closes the modal and shows a toast, instead of showing an inline error to let you fix the problem. Pulling this thread, I ended up:
Accessibility notes:
This is forward progress on accessibility, as the single-link errors now get read by VoiceOver. Neither the toasts or inline form errors are being read by VoiceOver for me, however. I think we should address that as a separate bug.