Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture error handling #3618

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

jcushman
Copy link
Contributor

Some improvements to error handling when capturing URLs, both single link and batch.

Single link errors are shown closer to the form, smaller, read by screen readers, and tweaked handling for a couple of messages:

image

I also looked at error handling for the batch capture modal and found that its error handling was pretty clunky -- if you don't put in urls, it closes the modal and shows a toast, instead of showing an inline error to let you fix the problem. Pulling this thread, I ended up:

  • refactoring FolderSelect to use a consistent dropdown inside and outside the batch capture modal
  • adding inline error handling to capturebatch
image

Accessibility notes:

This is forward progress on accessibility, as the single-link errors now get read by VoiceOver. Neither the toasts or inline form errors are being read by VoiceOver for me, however. I think we should address that as a separate bug.

@jcushman jcushman requested a review from a team as a code owner October 11, 2024 14:18
@jcushman jcushman requested review from cmsetzer and removed request for a team October 11, 2024 14:18
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.73%. Comparing base (161782c) to head (f3d5fd4).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3618   +/-   ##
========================================
  Coverage    69.73%   69.73%           
========================================
  Files           54       54           
  Lines         7326     7326           
========================================
  Hits          5109     5109           
  Misses        2217     2217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bensteinberg bensteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll get this on stage, where other people can have a look, as discussed.

@bensteinberg bensteinberg merged commit b8d6a86 into harvard-lil:develop Oct 11, 2024
2 checks passed
@bensteinberg bensteinberg removed the request for review from cmsetzer October 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants