Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Vue-dashboard file moves #3619

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

jcushman
Copy link
Contributor

This PR makes a bunch of cleanup moves now that we're moving the Vue dashboard out of a developer flag. These tend to step on file history, so I'm doing them in one big batch in the hopes of getting that out of the way:

  • Move everything out of the developer-playground flag. We're keeping the flag itself for potential use later.
  • Re-indent the new Vue files in frontend/ with two spaces, which is what we generally use for HTML/CSS/JS. (It would make sense at some point to adopt ESLint and Prettier, but I just did a quick effort with Pycharm for now since the files are moving anyway, in the hopes of reducing the diff size for that effort later.)
  • Delete all of the now-unused javascript from the old create page.
  • Move the frontend/ folder to static/frontend/. In working with Vite I found that it was hard to get both developer and production builds working with the right paths when we had Vue and CSS in different static folders.

@jcushman jcushman requested a review from a team as a code owner October 11, 2024 16:51
@jcushman jcushman requested review from teovin and removed request for a team October 11, 2024 16:51
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.73%. Comparing base (f3d5fd4) to head (62019e9).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3619   +/-   ##
========================================
  Coverage    69.73%   69.73%           
========================================
  Files           54       54           
  Lines         7326     7326           
========================================
  Hits          5109     5109           
  Misses        2217     2217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bensteinberg bensteinberg requested review from bensteinberg and removed request for teovin October 11, 2024 17:19
Copy link
Contributor

@bensteinberg bensteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll merge and deploy to stage. I think this will now require pretty thorough QA on stage before deploying to prod; if we need to do a bugfix before that QA happens, we might have to revert this PR and maybe the previous one, #3618, before applying the fix.

@bensteinberg bensteinberg merged commit 1a92e39 into harvard-lil:develop Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants