Convert the "updating" overlay to use Vuex actions with a slight delay #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This replaces the prop passed in to `IFXPageActionBar`
- If we’re using Vuex, the prop isn’t needed.
- It is available on pages that don’t use `IFXPageActionBar`. These are often pages that do their own submits.
- Gives us some tolerance for instant connections.
- This lets us use a timer to wait 1/3 of a second before committing the value. So there is less chance of a flash
- using the `getters.getTimer` returned the function, not the timer!
# Conflicts: # src/components/item/IFXItemCreateEditMixin.js # src/components/item/IFXItemEditableDetailMixin.js # src/components/page/IFXPageActionBar.vue
luthian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the overlay/spinner combo to the
IFXPageHeadercomponent as this component is in more pages thanIFXPageActionBar, especially pages that don't use the action bar. In addition, thez-indexis set to 300 to have the overlay appear over dialog boxes.There is also add a new Vuex module containing the
submittingstate variable; this is set/clear via a Vuex action,setSubmittingwhich takes atrueorfalse. To prevent any quick flashes of the overlay, the action will wait 1/3 second beforecommiting the change. Should a new request to set the state variable totruecome in, we will clear the current timer and start a new one; requests to set the state variable tofalsetake effect immediately.The previous method of passing state into
IFXPageActionBarhas been removed; now thesubmitSaveandsaveUpdatefunctions use the action to set/clear the state.To use this in other pages, first map the Vuex action with and then call the action with the appropriate payload:
Since we’re often mapping
showMessageanyway, this can be combined as...mapActions(['showMessage', 'submit/setSubmitting'])