Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the "updating" overlay to use Vuex actions with a slight delay #207

Open
wants to merge 11 commits into
base: ab_migrate
Choose a base branch
from
Open

Convert the "updating" overlay to use Vuex actions with a slight delay #207

wants to merge 11 commits into from

Commits on Jun 26, 2024

  1. Create namespaces Vuex module for submitting 

    - This replaces the prop passed in to `IFXPageActionBar`
    @luthian
    luthian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d7f0a87 View commit details
    Browse the repository at this point in the history

  2. Export out the submit Vuex module

    @luthian
    luthian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d64475d View commit details
    Browse the repository at this point in the history

  3. Use the Vuex submit store rather than a separate data variable

    @luthian
    luthian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8f83c4c View commit details
    Browse the repository at this point in the history

  4. Use the Vuex store instead of a prop to control the overlay

    @luthian
    luthian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9d14856 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Removed submitting prop to IFXPageActionBar 

    - If we’re using Vuex, the prop isn’t needed.
    @luthian
    luthian committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0c3e294 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. move overlay into IFXPageHeader 

    - It is available on pages that don’t use `IFXPageActionBar`. These are often pages that do their own submits.
    @luthian
    luthian committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d770bdf View commit details
    Browse the repository at this point in the history

  2. Make setSubmitting action wait 1/3 second before setting value 

    - Gives us some tolerance for instant connections.
    @luthian
    luthian committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    69b57b7 View commit details
    Browse the repository at this point in the history

  3. Bump z-index of overlay to put it over dialog boxes

    @luthian
    luthian committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    31c2997 View commit details
    Browse the repository at this point in the history

  4. Use the setSubmitting action rather than commit 

    - This lets us use a timer to wait 1/3 of a second before committing the value. So there is less chance of a flash
    @luthian
    luthian committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2b8b892 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Fix getting current timer and use constant for a DELAY 

    - using the `getters.getTimer` returned the function, not the timer!
    @luthian
    luthian committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9dfaace View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ab_migrate' into dda_spinner_on_submit_vuex_pt_2 

    # Conflicts:
#	src/components/item/IFXItemCreateEditMixin.js
#	src/components/item/IFXItemEditableDetailMixin.js
#	src/components/page/IFXPageActionBar.vue
    @luthian
    luthian committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    52cb7c8 View commit details
    Browse the repository at this point in the history