Escape the group_label when rendering it
#2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m 👍🤘 — I assume you’ve double-checked for double-escaping, but that would be my only concern. bon-jovi-livin-on-a-prayer.gif |
added 3 commits
June 7, 2018 16:21
Quick note: this uses the idiom `div.innerHTML = tmpl` instead of what we've been using in our other tests, which is `div.update(tmpl)` because of some fun stuff that Prototype does when one calls `update`: docs: http://api.prototypejs.org/dom/Element/prototype/update/ Relevant quote for funsies: > If newContent is a string and contains one or more inline <script> > tags, the scripts are scheduled to be evaluated after a very brief pause > (using Function#defer) to allow the browser to finish updating the DOM. Yeah.
satchmorun
force-pushed
the
fix-group-label-xss-vulnerability
branch
from
0fec73f
to
5ae77b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2996.
An easy fix, we were simply missing a call to
this.escape_html. To be honest, I'm surprised this hasn't been a reported issue yet.As a bonus, there are even tests for red-greening the fix!
Many thanks to @cade for his assistance with figuring out was was going on in the Ancient Technology™ test (read: Prototype JS).