Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape the group_label when rendering it #2997

Merged
merged 3 commits into from
Jun 8, 2018
Merged

Escape the group_label when rendering it #2997

merged 3 commits into from
Jun 8, 2018

Commits on Jun 7, 2018

  1. Test to ensure we're escaping group labels from jQuery

    Arun Srinivasan committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    a4cf007 View commit details
    Browse the repository at this point in the history

  2. Test to ensure we're escaping group labels from Prototype 

    Quick note: this uses the idiom `div.innerHTML = tmpl` instead of what we've
been using in our other tests, which is `div.update(tmpl)` because of some fun
stuff that Prototype does when one calls `update`:

docs: http://api.prototypejs.org/dom/Element/prototype/update/

Relevant quote for funsies:

> If newContent is a string and contains one or more inline <script>
> tags, the scripts are scheduled to be evaluated after a very brief pause
> (using Function#defer) to allow the browser to finish updating the DOM.

Yeah.
    Arun Srinivasan committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    053057e View commit details
    Browse the repository at this point in the history

  3. Escape the item's group_label when rendering it.

    Arun Srinivasan committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    5ae77b1 View commit details
    Browse the repository at this point in the history