Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): enhance file copy function of k8 class based on status code #758

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Feb 14, 2024

Description

This pull request changes the following:

  • pick hasDir and copyTo functionalities of k8 class from code-cleanup branch

I picked the changes from an old branch code-cleanup that has Nathan's updates. However that branch now triggers a lot of conflicts since fullstack-network-manager directory was renamed to solo. So this PR is an attempt to recover the key changes in k8 class.

Related Issues

  • Closes #

@leninmehedy leninmehedy changed the title fix: enhance hasDir and copyTo functionalities of k8s fix: enhance file copy functionalities of k8s Feb 14, 2024
@leninmehedy leninmehedy changed the title fix: enhance file copy functionalities of k8s fix: enhance file copy functionalities of k8s based on status code Feb 14, 2024
@leninmehedy leninmehedy changed the title fix: enhance file copy functionalities of k8s based on status code fix: enhance file copy functionalities of k8 class based on status code Feb 14, 2024
@leninmehedy leninmehedy changed the title fix: enhance file copy functionalities of k8 class based on status code fix: enhance file copy function of k8 class based on status code Feb 14, 2024
@leninmehedy leninmehedy changed the title fix: enhance file copy function of k8 class based on status code fix(cli): enhance file copy function of k8 class based on status code Feb 14, 2024
Copy link

Unit Test Results

  26 files  ±0    26 suites  ±0   57s ⏱️ -3s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit ac38388. ± Comparison against base commit 167fb3c.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (167fb3c) 67.51% compared to head (ac38388) 67.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #758   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63           

Impacted file tree graph

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leninmehedy leninmehedy self-assigned this Feb 14, 2024
@leninmehedy leninmehedy merged commit e6b5602 into main Feb 14, 2024
23 of 26 checks passed
@leninmehedy leninmehedy deleted the code-cleanup-2 branch February 14, 2024 22:58
swirlds-automation added a commit that referenced this pull request Feb 23, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-02-23)

### Features

* allow user to create and update accounts with funds from treasury  ([#759](#759)) ([cd2567b](cd2567b))
* rekey special accounts at startup so they are not using genesis keys ([#733](#733)) ([096b5c3](096b5c3))

### Bug Fixes

* **chart:** use selected paths for volumes mount under hgcapp directory ([#751](#751)) ([e1d1c61](e1d1c61))
* **cli:** enhance file copy function of k8 class based on status code ([#758](#758)) ([e6b5602](e6b5602))
* **cli:** refactor config manager with each function having a single responsibility to avoid confusion ([#750](#750)) ([7f45864](7f45864))
* correct path names for volumes and upgrade minio ([#762](#762)) ([a8ec593](a8ec593))
* do version check for dependencies ([#755](#755)) ([520cb47](520cb47))
* **docker:** update location for entrypoint.sh ([#754](#754)) ([7cf02f6](7cf02f6))
* set the mirror node importer addressbook to an invalid value to prevent it from starting ([#777](#777)) ([a12cb1c](a12cb1c))
* use default values for flags during init ([#753](#753)) ([167fb3c](167fb3c))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants