Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record file hash mismatch #157

Closed
gregscullard opened this issue Aug 29, 2019 · 0 comments · Fixed by #159
Closed

Record file hash mismatch #157

gregscullard opened this issue Aug 29, 2019 · 0 comments · Fixed by #159
Assignees
Labels
bug Type: Something isn't working downloader Area: S3 downloader P1
Milestone

Comments

@gregscullard
Copy link
Contributor

Detailed Description
Occasionally, the recordDownloader reports a mismatch between the previous hash contained in the (n) file and the hash of the (n-1) file. This only occurs when the downloader and the parser run together.

Actual Behavior
Ensure the t_application_status table is clear for the following status_values

update t_application_status set status_value = '' where status_code ='LAST_PROCESSED_RECORD_HASH';
update t_application_status set status_value = '' where status_code ='LAST_VALID_DOWNLOADED_RECORD_FILE';
update t_application_status set status_value = '' where status_code ='LAST_VALID_DOWNLOADED_RECORD_FILE_HASH';

Start the recordParser
Start the recordDownloader
Observe the output from the recordDownloader, it will eventually complain about mismatching hashes when there isn't.

If you stop the parser, clear the t_application_values table again and delete any downloaded files, then run the downloader alone, previously reported mismatches no longer occur. This proves that the file hash sequence is correct and the mirror node is incorrectly reporting errors.

Expected Behavior
There is no reported mismatch of hashes when the files themselves are perfectly fine. Only true mismatches are reported.

Environment:
N/A

@gregscullard gregscullard added bug Type: Something isn't working OABlocker labels Aug 29, 2019
@gregscullard gregscullard added this to the 0.1.0 milestone Aug 29, 2019
@gregscullard gregscullard self-assigned this Aug 29, 2019
gregscullard pushed a commit that referenced this issue Aug 30, 2019
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
mike-burrage-hedera added a commit that referenced this issue Aug 30, 2019
…type not known

Ensures downloaded files are validated for previous hash continuity before being moved to /valid
modify the way to calculate RecordStream File Hash; Add a test; #157
Use the newer file hash calculator for recordStream files
PR Comments

Signed-off-by: Mike Burrage <mike.burrage@hedera.com>
@steven-sheehy steven-sheehy changed the title RecordDownloader: Occasional previous hash mismatch Record file hash mismatch Aug 30, 2019
@steven-sheehy steven-sheehy added downloader Area: S3 downloader P1 labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working downloader Area: S3 downloader P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants