Record file hash mismatch #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-sheehy
requested changes
Aug 30, 2019
src/main/java/com/hedera/databaseUtilities/ApplicationStatus.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/V1.10.1__freeze_transaction.sql
Outdated
Show resolved
Hide resolved
src/main/java/com/hedera/recordFileLogger/RecordFileLogger.java
Outdated
Show resolved
Hide resolved
2 tasks
gregscullard
force-pushed
the
157-file-hash-mismatch
branch
2 times, most recently
from
b1e52bb
to
f390fef
Compare
…type not known Signed-off-by: Greg Scullard <gregscullard@hedera.com>
…sed by mirror node) Signed-off-by: Greg Scullard <gregscullard@hedera.com>
…efore being moved to /valid Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
gregscullard
force-pushed
the
157-file-hash-mismatch
branch
from
f390fef
to
bf1b343
Compare
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
…type not known Ensures downloaded files are validated for previous hash continuity before being moved to /valid modify the way to calculate RecordStream File Hash; Add a test; #157 Use the newer file hash calculator for recordStream files PR Comments Signed-off-by: Mike Burrage <mike.burrage@hedera.com>
mike-burrage-hedera
force-pushed
the
157-file-hash-mismatch
branch
from
d92dfce
to
7dad85d
Compare
steven-sheehy
requested changes
Aug 30, 2019
…mirrornode into 157-file-hash-mismatch
|
My PR #170 added record download tests, but the test records are probably the old format. Hopefully the tests still pass and we can add some v2 test data in a later PR. |
added 2 commits
September 1, 2019 22:04
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
|
Other than still needing to calculate the event hash with the correct method this LGTM |
added 2 commits
September 2, 2019 10:55
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Done, also removed now obsolete |
steven-sheehy
requested changes
Sep 2, 2019
| @@ -62,8 +62,9 @@ | |||
|
|
|||
| private static final Long SCALAR = 1_000_000_000L; | |||
|
|
|||
| // private static final byte TYPE_PREV_HASH = 1; // next 48 bytes are hash384 of previous files | |||
| // private static final byte TYPE_RECORD = 2; // next data type is transaction and its record | |||
| static final int RECORD_FORMAT_VERSION = 2; | |||
There was a problem hiding this comment.
Remove these added static variables as they're not used.
added 2 commits
September 2, 2019 17:26
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
|
Signed-off-by: Greg Scullard <gregscullard@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
This fixes a number of issues related to record file hash mismatches
-When downloading and parsing files in parallel, the two processes would overlap on files in /valid and a parsed file would move from /valid to /processed resulting in a gap during hash sequence validation in the downloader
Which issue(s) this PR fixes:
Fixes #157
Checklist