Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ZFS ARC max/min before importing zpool #9711

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

xin-hedera
Copy link
Collaborator

Description:

This PR fixes the ZFS ARC max issue

  • Set ZFS ARC max/min before importing zpool

Related issue(s):

Fixes #9629

Notes for reviewer:

Tested with mainnet disk / pool size, arc_summary with the fix

ARC status:                                                      HEALTHY
        Memory throttle count:                                         0

ARC size (current):                                     1.2 %   23.6 MiB
        Target size (adaptive):                       100.0 %    2.0 GiB
        Min size (hard limit):                         25.0 %  512.0 MiB
        Max size (high water):                            4:1    2.0 GiB
        Most Frequently Used (MFU) cache size:          2.9 %  639.0 KiB
        Most Recently Used (MRU) cache size:           97.1 %   21.0 MiB
        Metadata cache size (hard limit):              75.0 %    1.5 GiB
        Metadata cache size (current):                  1.5 %   23.6 MiB
        Dnode cache size (hard limit):                 10.0 %  153.6 MiB
        Dnode cache size (current):                     0.6 %  981.3 KiB

Note the value of ARC min isn't important, 1/4 is kind of a randomly picked ratio. However we want to set it before setting max, since the new max value will get ignored if it's smaller than the current min value.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Xin Li <xin@hashgraph.com>
@xin-hedera xin-hedera added this to the 0.118.0 milestone Nov 5, 2024
@xin-hedera xin-hedera self-assigned this Nov 5, 2024
@xin-hedera xin-hedera linked an issue Nov 5, 2024 that may be closed by this pull request
@xin-hedera xin-hedera added bug Type: Something isn't working database Area: Database labels Nov 5, 2024
@xin-hedera xin-hedera marked this pull request as ready for review November 5, 2024 17:18
@xin-hedera xin-hedera requested a review from a team as a code owner November 5, 2024 17:18
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (1df049c) to head (be7f70e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9711      +/-   ##
============================================
+ Coverage     92.23%   92.33%   +0.09%     
+ Complexity     7628     7524     -104     
============================================
  Files           937      919      -18     
  Lines         32115    31859     -256     
  Branches       4067     4045      -22     
============================================
- Hits          29621    29416     -205     
+ Misses         1542     1496      -46     
+ Partials        952      947       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera merged commit 069412c into main Nov 5, 2024
35 checks passed
@xin-hedera xin-hedera deleted the 9629-zfs-arc-max-isnt-honored branch November 5, 2024 20:10
bilyana-gospodinova pushed a commit that referenced this pull request Nov 6, 2024
- Set ZFS ARC max/min before importing zpool

Signed-off-by: Xin Li <xin@hashgraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working database Area: Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZFS ARC max isn't honored
3 participants