-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ZFS ARC max/min before importing zpool #9711
Conversation
Signed-off-by: Xin Li <xin@hashgraph.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9711 +/- ##
============================================
+ Coverage 92.23% 92.33% +0.09%
+ Complexity 7628 7524 -104
============================================
Files 937 919 -18
Lines 32115 31859 -256
Branches 4067 4045 -22
============================================
- Hits 29621 29416 -205
+ Misses 1542 1496 -46
+ Partials 952 947 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Set ZFS ARC max/min before importing zpool Signed-off-by: Xin Li <xin@hashgraph.com>
Description:
This PR fixes the ZFS ARC max issue
Related issue(s):
Fixes #9629
Notes for reviewer:
Tested with mainnet disk / pool size, arc_summary with the fix
Note the value of ARC min isn't important, 1/4 is kind of a randomly picked ratio. However we want to set it before setting max, since the new max value will get ignored if it's smaller than the current min value.
Checklist