-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBJ Compiler fails on comment preceding reserved
field or syntax
keyword
#217
Comments
PBJ also appears to fail if a comment precedes the |
jsync-swirlds
changed the title
PBJ Compiler fails on comment preceding
PBJ Compiler fails on comment preceding May 9, 2024
reserved
fieldreserved
field or syntax
keyword
jsync-swirlds
added a commit
that referenced
this issue
Jan 9, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added docComment before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, #319 still prevents using docComment before `reserved`. Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 9, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added skippedDocComment before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 10, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added skippedDocComment before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 10, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added documentation comments before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 10, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added documentation comments before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 13, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added documentation comments before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 13, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added documentation comments before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 14, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added documentation comments before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
added a commit
that referenced
this issue
Jan 14, 2025
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added documentation comments before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Placing a field comment before a
reserved
field causes PBJ to fail.To reproduce:
Add a reserved field with a field comment in any
.proto
file:The PBJ compiler fails with an error (example from contract_types.proto):
protoc
properly ignores the comment, rather than failing to parse the file properly.The grammar for PBJ appears to be missing a term for the comment preceding the
reserved
keyword.The text was updated successfully, but these errors were encountered: