fix: Fix a few small issues and change to SPDX identifiers #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #145 * Renamed `intergration` to `integration` globally * Fixes #217 * Added skippedDocComment before `syntax`, `import`, `package`, `option`, and `reserved` keywords in grammar * The root cause is the change to docComment to make it non-skipped, so we have to add it everywhere. Skipped comments (the `//` type) can be absolutely anywhere because the grammar _skips_ them. * Note, this _might_ also fix #319 Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
* Replaced copyright notices with SPDX license identifiers * Added SPDX identifiers where needed * In particular, the integration tests had no headers, so added to all files. Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
* In pbj-integration * Also ran a spotlessApply to fix _many_ formatting issues. * In pbj-core * Ran spotlessApply, which clearly hasn't been done in a very long time. Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full codebase
pbj integration tests
intergrationtointegrationgloballypbj core
syntax,import,package,option,and
reservedkeywords in grammarwe have to add it everywhere. Skipped comments (the
//type) can beabsolutely anywhere because the grammar skips them.
keyword) will be needed