Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need to update agreement key together with signing key #539

Merged
merged 54 commits into from
Sep 4, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Sep 3, 2024

Description

This pull request changes the following:

  • Add new flags for agreement key files
  • Update agreement key together with signing key since agreement key is generated using signing key as root certificate

Related Issues

JeffreyDallas and others added 30 commits August 16, 2024 15:36
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…node-delete

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/node.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…node-delete

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	package-lock.json
#	package.json
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners September 3, 2024 22:02
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/flags.mjs
#	src/commands/node.mjs
#	test/e2e/commands/node-update.test.mjs
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   45s ⏱️ ±0s
126 tests ±0  126 ✅ ±0  0 💤 ±0  0 ❌ ±0 
152 runs  ±0  152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   1m 32s ⏱️ -5s
126 tests ±0  126 ✅ ±0  0 💤 ±0  0 ❌ ±0 
152 runs  ±0  152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node PEM Stop Tests Coverage Report

12 tests  ±0   12 ✅ ±0   2m 33s ⏱️ -4s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Relay Tests Coverage Report

1 files  ±0  1 suites  ±0   2m 33s ⏱️ -10s
5 tests ±0  5 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node PFX Kill Tests Coverage Report

12 tests  ±0   12 ✅ ±0   2m 47s ⏱️ -6s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Tests Coverage Report

57 tests  ±0   57 ✅ +1   3m 15s ⏱️ - 1m 4s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌  - 1 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Update Tests Coverage Report

11 tests  +2   11 ✅ +5   5m 6s ⏱️ + 2m 18s
 1 suites ±0    0 💤  - 3 
 1 files   ±0    0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Delete Tests Coverage Report

9 tests  ±0   9 ✅ ±0   5m 51s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Mirror Node Tests Coverage Report

 1 files   1 suites   3m 43s ⏱️
12 tests 12 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit c4b26d5.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Local Build Tests Coverage Report

8 tests  ±0   8 ✅ ±0   2m 38s ⏱️ -5s
2 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

E2E Node Add Tests Coverage Report

20 tests  ±0   20 ✅ ±0   13m 36s ⏱️ - 1m 5s
 2 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c4b26d5. ± Comparison against base commit 80639a9.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 80639a91 22.22%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (80639a9) Report Missing Report Missing Report Missing
Head commit (c4b26d5) 4107 3219 78.38%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#539) 9 2 22.22%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (c81c76a) to head (c4b26d5).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   81.66%   82.72%   +1.06%     
==========================================
  Files          35       36       +1     
  Lines        4429     4904     +475     
  Branches      671      691      +20     
==========================================
+ Hits         3617     4057     +440     
- Misses        812      847      +35     
Files with missing lines Coverage Δ
src/commands/flags.mjs 96.00% <100.00%> (+0.47%) ⬆️
src/commands/node.mjs 82.77% <100.00%> (+4.02%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit f9b2e21 into main Sep 4, 2024
44 of 45 checks passed
@jeromy-cannon jeromy-cannon deleted the 00474-D-node-delete branch September 4, 2024 12:34
swirlds-automation added a commit that referenced this pull request Sep 6, 2024
## [0.29.0](v0.28.1...v0.29.0) (2024-09-06)

### Features

* add local build support for node add command ([#509](#509)) ([a7e778f](a7e778f))
* add node delete and update command ([#500](#500)) ([9f8549a](9f8549a))
* use k8s secrets to store node gossip and grpc tls keys and mount them ([#499](#499)) ([ede1842](ede1842))

### Bug Fixes

* added missing async/await where needed ([#551](#551)) ([d8e5032](d8e5032))
* improve types in JSDoc and fix typo in '/src/commands/account.mjs' ([#507](#507)) ([74c9e2c](74c9e2c))
* need to update agreement key together with signing key ([#539](#539)) ([f9b2e21](f9b2e21))
* removed the custom ip address logic and '@hashgraph/proto' ([#518](#518)) ([c81c76a](c81c76a))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add solo node update subcommand
3 participants