Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the custom ip address logic and '@hashgraph/proto' #518

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Aug 28, 2024

Description

This pull request changes the following:

  • removed the custom ip address logic and '@hashgraph/proto'

Related Issues

Signed-off-by: instamenta <instamenta@abv.bg>
@instamenta instamenta requested review from a team and leninmehedy as code owners August 28, 2024 10:46
Copy link
Contributor

Unit Test Results - Linux

  1 files   19 suites   47s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs  152 ✅ 0 💤 0 ❌

Results for commit a98e5dd.

Copy link
Contributor

Unit Test Results - Windows

  1 files   19 suites   1m 33s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs  152 ✅ 0 💤 0 ❌

Results for commit a98e5dd.

@instamenta instamenta changed the title removed the custom ip address logic and '@hashgraph/proto' chore: removed the custom ip address logic and '@hashgraph/proto' Aug 28, 2024
Copy link
Contributor

E2E Node PFX Kill Tests Coverage Report

12 tests   12 ✅  2m 45s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit a98e5dd.

Copy link
Contributor

E2E Node PEM Stop Tests Coverage Report

12 tests   12 ✅  2m 39s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit a98e5dd.

Copy link
Contributor

E2E Relay Tests Coverage Report

1 files  1 suites   2m 40s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs  6 ✅ 0 💤 0 ❌

Results for commit a98e5dd.

Copy link
Contributor

E2E Tests Coverage Report

57 tests   57 ✅  3m 51s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit a98e5dd.

Copy link
Contributor

E2E Node Local Build Tests Coverage Report

8 tests   8 ✅  2m 46s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit a98e5dd.

Copy link
Contributor

E2E Node Add Tests Coverage Report

10 tests   10 ✅  6m 35s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit a98e5dd.

Copy link
Contributor

E2E Mirror Node Tests Coverage Report

 1 files   1 suites   3m 38s ⏱️
12 tests 12 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit a98e5dd.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for f11af201 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f11af20) Report Missing Report Missing Report Missing
Head commit (a98e5dd) 3700 3033 81.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#518) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (c2200aa) to head (a98e5dd).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   81.52%   81.68%   +0.16%     
==========================================
  Files          35       35              
  Lines        4449     4429      -20     
  Branches      757      753       -4     
==========================================
- Hits         3627     3618       -9     
+ Misses        822      811      -11     
Files with missing lines Coverage Δ
src/core/account_manager.mjs 80.49% <100.00%> (+2.72%) ⬆️

Impacted file tree graph

@jeromy-cannon jeromy-cannon changed the title chore: removed the custom ip address logic and '@hashgraph/proto' fix: removed the custom ip address logic and '@hashgraph/proto' Aug 28, 2024
@jeromy-cannon jeromy-cannon merged commit c81c76a into main Aug 28, 2024
40 of 42 checks passed
@jeromy-cannon jeromy-cannon deleted the 493-remove-custom-ip-address-logic-for-mirror-node-address-book-and-use-dab branch August 28, 2024 15:12
swirlds-automation added a commit that referenced this pull request Sep 6, 2024
## [0.29.0](v0.28.1...v0.29.0) (2024-09-06)

### Features

* add local build support for node add command ([#509](#509)) ([a7e778f](a7e778f))
* add node delete and update command ([#500](#500)) ([9f8549a](9f8549a))
* use k8s secrets to store node gossip and grpc tls keys and mount them ([#499](#499)) ([ede1842](ede1842))

### Bug Fixes

* added missing async/await where needed ([#551](#551)) ([d8e5032](d8e5032))
* improve types in JSDoc and fix typo in '/src/commands/account.mjs' ([#507](#507)) ([74c9e2c](74c9e2c))
* need to update agreement key together with signing key ([#539](#539)) ([f9b2e21](f9b2e21))
* removed the custom ip address logic and '@hashgraph/proto' ([#518](#518)) ([c81c76a](c81c76a))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom IP address logic for Mirror Node address book and use DAB
3 participants