-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed the custom ip address logic and '@hashgraph/proto' #518
fix: removed the custom ip address logic and '@hashgraph/proto' #518
Conversation
Signed-off-by: instamenta <instamenta@abv.bg>
Unit Test Results - Linux 1 files 19 suites 47s ⏱️ Results for commit a98e5dd. |
Unit Test Results - Windows 1 files 19 suites 1m 33s ⏱️ Results for commit a98e5dd. |
E2E Node PFX Kill Tests Coverage Report12 tests 12 ✅ 2m 45s ⏱️ Results for commit a98e5dd. |
E2E Node PEM Stop Tests Coverage Report12 tests 12 ✅ 2m 39s ⏱️ Results for commit a98e5dd. |
E2E Relay Tests Coverage Report1 files 1 suites 2m 40s ⏱️ Results for commit a98e5dd. |
E2E Tests Coverage Report57 tests 57 ✅ 3m 51s ⏱️ Results for commit a98e5dd. |
E2E Node Local Build Tests Coverage Report8 tests 8 ✅ 2m 46s ⏱️ Results for commit a98e5dd. |
E2E Node Add Tests Coverage Report10 tests 10 ✅ 6m 35s ⏱️ Results for commit a98e5dd. |
E2E Mirror Node Tests Coverage Report 1 files 1 suites 3m 38s ⏱️ Results for commit a98e5dd. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 81.52% 81.68% +0.16%
==========================================
Files 35 35
Lines 4449 4429 -20
Branches 757 753 -4
==========================================
- Hits 3627 3618 -9
+ Misses 822 811 -11
|
## [0.29.0](v0.28.1...v0.29.0) (2024-09-06) ### Features * add local build support for node add command ([#509](#509)) ([a7e778f](a7e778f)) * add node delete and update command ([#500](#500)) ([9f8549a](9f8549a)) * use k8s secrets to store node gossip and grpc tls keys and mount them ([#499](#499)) ([ede1842](ede1842)) ### Bug Fixes * added missing async/await where needed ([#551](#551)) ([d8e5032](d8e5032)) * improve types in JSDoc and fix typo in '/src/commands/account.mjs' ([#507](#507)) ([74c9e2c](74c9e2c)) * need to update agreement key together with signing key ([#539](#539)) ([f9b2e21](f9b2e21)) * removed the custom ip address logic and '@hashgraph/proto' ([#518](#518)) ([c81c76a](c81c76a))
🎉 This PR is included in version 0.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This pull request changes the following:
Related Issues