feat(logging): Add the new custom process output class and inject it into the default list renderer options #622

instamenta · 2024-09-20T08:54:16Z

Description

Add the new custom process output class and inject it into the default list renderer options
Fix warnings in IDE - ( type mismatches, etc. )
Add delay on the Node.checkNetworkNodeActiveness since it prevents the gRPC service error

Related Issues

Closes #
- 581
- 546

…t list renderer options Signed-off-by: instamenta <instamenta@abv.bg>

github-actions · 2024-09-20T08:56:34Z

Unit Test Results - Linux

1 files ±0 19 suites ±0 28s ⏱️ -1s
119 tests ±0 119 ✅ ±0 0 💤 ±0 0 ❌ ±0
145 runs ±0 145 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit ae85dbe. ± Comparison against base commit 3db7e08.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-20T08:57:34Z

Unit Test Results - Windows

1 files ±0 19 suites ±0 57s ⏱️ +2s
119 tests ±0 119 ✅ ±0 0 💤 ±0 0 ❌ ±0
145 runs ±0 145 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit ae85dbe. ± Comparison against base commit 3db7e08.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-20T09:21:14Z

E2E Test Report

10 files ±0 20 suites ±0 49m 19s ⏱️ -13s
170 tests ±0 170 ✅ ±0 0 💤 ±0 0 ❌ ±0
173 runs ±0 173 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit f52d111. ± Comparison against base commit e4932c4.

github-actions · 2024-09-20T09:21:14Z

E2E Test Report

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit ae85dbe. ± Comparison against base commit 3db7e08.

♻️ This comment has been updated with latest results.

codacy-production · 2024-09-20T09:21:24Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.03% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`3db7e08`)	4173	3355	80.40%
Head commit (`ae85dbe`)	4175 (+2)	3358 (+3)	80.43% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#622)	40	40	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-09-20T09:21:58Z

Codecov Report

Attention: Patch coverage is 94.89796% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (3db7e08) to head (ae85dbe).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/node.mjs	93.15%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files          37       37           
  Lines        5016     5012    -4     
  Branches      768      691   -77     
=======================================
- Hits         4026     4023    -3     
+ Misses        989      988    -1     
  Partials        1        1

Files with missing lines	Coverage Δ
src/commands/account.mjs	`68.29% <100.00%> (ø)`
src/commands/base.mjs	`95.23% <100.00%> (ø)`
src/commands/mirror_node.mjs	`66.24% <ø> (ø)`
src/commands/network.mjs	`68.94% <ø> (ø)`
src/commands/relay.mjs	`73.13% <ø> (ø)`
src/core/account_manager.mjs	`80.73% <100.00%> (ø)`
src/core/chart_manager.mjs	`89.55% <100.00%> (ø)`
src/core/config_manager.mjs	`91.35% <100.00%> (ø)`
...rc/core/dependency_managers/dependency_manager.mjs	`100.00% <100.00%> (ø)`
...re/dependency_managers/helm_dependency_manager.mjs	`90.47% <100.00%> (ø)`
... and 13 more

src/core/process_output.mjs

Signed-off-by: instamenta <instamenta@abv.bg>

…e grpc service error Signed-off-by: instamenta <instamenta@abv.bg>

src/core/process_output.mjs

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Signed-off-by: instamenta <instamenta@abv.bg>

## [0.31.0](v0.30.1...v0.31.0) (2024-10-04) ### Features * Add '--mirror-node-version' flag to override default mirror node version ([#616](#616)) ([e4932c4](e4932c4)) * add quiet flag ([#621](#621)) ([b068c8f](b068c8f)) * convert hugo docs workflow calls to use Taskfile task ([#642](#642)) ([ae8d8bb](ae8d8bb)) * ensured user-provided values file takes precedence over solo-generated values ([#615](#615)) ([1b0ffc9](1b0ffc9)) * **logging:** Add the new custom process output class and inject it into the default list renderer options ([#622](#622)) ([efa1783](efa1783)) * separate commands for solo node delete ([#597](#597)) ([b251276](b251276)) * Separate network upgrade and freeze from node update/add/delete command ([#628](#628)) ([9b17937](9b17937)) ### Bug Fixes * Direct calling of node stop and start commands ([#636](#636)) ([7749b04](7749b04)) * **docs:** resolve issues due to npx in taskfile for the custom-network-config example ([038e6df](038e6df)) * jsdoc failed but ci job not failed ([#608](#608)) ([3f838f6](3f838f6)) * specify jvm env variables explicitly for local profile ([#405](#405)) ([3db7e08](3db7e08)) * **tests:** start Kind cluster on demand if not having a kube config errors ([#624](#624)) ([538e40d](538e40d)) * upgrade eslint config away from abandoned plugin ([#643](#643)) ([84d3dc5](84d3dc5))

swirlds-automation · 2024-10-04T16:32:30Z

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Add the new custom process output class and inject it into the defaul…

f52d111

…t list renderer options Signed-off-by: instamenta <instamenta@abv.bg>

instamenta requested a review from jeromy-cannon September 20, 2024 08:54

instamenta self-assigned this Sep 20, 2024

instamenta requested review from leninmehedy and a team as code owners September 20, 2024 08:54

instamenta linked an issue Sep 20, 2024 that may be closed by this pull request

Update logging.mjs Logger to be a class #581

Closed

6 tasks

jeromy-cannon reviewed Sep 20, 2024

View reviewed changes

src/core/process_output.mjs Outdated Show resolved Hide resolved

instamenta added 4 commits September 20, 2024 16:54

Reduce the overall noise from warnings and remove obsolete code

1c03881

Signed-off-by: instamenta <instamenta@abv.bg>

fix the new custom extended processOutput class

e85ec64

Signed-off-by: instamenta <instamenta@abv.bg>

make the jsdoc's friendly with the 'Code Style' enforcer

b2da256

Signed-off-by: instamenta <instamenta@abv.bg>

add delay on the Node.checkNetworkNodeActiveness since it prevents th…

b7bf6d4

…e grpc service error Signed-off-by: instamenta <instamenta@abv.bg>

jeromy-cannon reviewed Sep 30, 2024

View reviewed changes

src/core/process_output.mjs Show resolved Hide resolved

JeffreyDallas and others added 2 commits September 30, 2024 14:44

split lines

ac35913

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

merged with main

ae85dbe

Signed-off-by: instamenta <instamenta@abv.bg>

jeromy-cannon approved these changes Oct 1, 2024

View reviewed changes

jeromy-cannon merged commit efa1783 into main Oct 1, 2024
36 checks passed

jeromy-cannon deleted the 00581-update-loggingmjs-logger-to-be-a-class branch October 1, 2024 14:11

swirlds-automation added the released label Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(logging): Add the new custom process output class and inject it into the default list renderer options #622

feat(logging): Add the new custom process output class and inject it into the default list renderer options #622

instamenta commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024 •

edited

Loading

codacy-production bot commented Sep 20, 2024 •

edited

Loading

codecov bot commented Sep 20, 2024 •

edited

Loading

swirlds-automation commented Oct 4, 2024

feat(logging): Add the new custom process output class and inject it into the default list renderer options #622

feat(logging): Add the new custom process output class and inject it into the default list renderer options #622

Conversation

instamenta commented Sep 20, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Sep 20, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Sep 20, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Sep 20, 2024

E2E Test Report

github-actions bot commented Sep 20, 2024 • edited Loading

E2E Test Report

codacy-production bot commented Sep 20, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Sep 20, 2024 • edited Loading

Codecov Report

swirlds-automation commented Oct 4, 2024

instamenta commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

codacy-production bot commented Sep 20, 2024 •

edited

Loading

codecov bot commented Sep 20, 2024 •

edited

Loading