Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cluster command end to end test #127

Closed
wants to merge 41 commits into from
Closed

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Mar 5, 2024

Description

This pull request changes the following:

  • Adding an end-to-end test for cluster command

Related Issues

JeffreyDallas and others added 5 commits March 4, 2024 09:58
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners March 5, 2024 10:51
@JeffreyDallas JeffreyDallas marked this pull request as draft March 5, 2024 10:51
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Unit Test Results

  1 files  ±0   16 suites  ±0   1m 16s ⏱️ +8s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
134 runs  ±0  134 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c1d5d05. ± Comparison against base commit a27d1d2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 5, 2024

E2E Test Results

63 tests  +8   63 ✅ +8   6m 15s ⏱️ +43s
 8 suites +1    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c1d5d05. ± Comparison against base commit a27d1d2.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link

codacy-production bot commented Mar 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+3.38% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a27d1d2) 2588 1803 69.67%
Head commit (c1d5d05) 2601 (+13) 1900 (+97) 73.05% (+3.38%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#127) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base (a27d1d2) to head (ffdac9c).
Report is 1 commits behind head on main.

❗ Current head ffdac9c differs from pull request most recent head c1d5d05. Consider uploading reports for the commit c1d5d05 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   69.14%   72.70%   +3.56%     
==========================================
  Files          32       32              
  Lines        3095     3111      +16     
  Branches      478      484       +6     
==========================================
+ Hits         2140     2262     +122     
+ Misses        955      849     -106     
Files Coverage Δ
src/commands/cluster.mjs 58.91% <100.00%> (+58.91%) ⬆️
test/test_util.js 90.47% <100.00%> (+3.33%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@leninmehedy
Copy link
Member

Let's split this PR and address in separate tickets as outlined here:

#137
#138

@JeffreyDallas JeffreyDallas changed the title test: add cluster setup end to en test test: add cluster setup end to end test Mar 11, 2024
JeffreyDallas and others added 10 commits March 13, 2024 09:15
…test

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/cluster.mjs
#	test/e2e/setup-e2e.sh
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as ready for review March 21, 2024 03:50
leninmehedy and others added 4 commits March 21, 2024 14:52
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
…r setup chart

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@JeffreyDallas JeffreyDallas changed the title test: add cluster setup end to end test test: add cluster command end to end test Mar 22, 2024
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
Copy link
Contributor Author

I made some mistake when trying to rebase,
Opened a clean and new PR #179

@JeffreyDallas JeffreyDallas deleted the add_e2e_test branch March 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement e2e tests for cluster command
3 participants