feat: new command to save state files and upload state files #849

JeffreyDallas · 2024-11-20T02:31:26Z

Description

This pull request changes the following:

add new subcommand to node command to download state files
add new flag to node start to upload zipped state file before node start

Related Issues

Closes Be able to launch a network from saved state #817

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

github-actions · 2024-11-20T02:33:30Z

Unit Test Results - Linux

1 files ±0 36 suites ±0 4s ⏱️ -1s
109 tests ±0 109 ✅ ±0 0 💤 ±0 0 ❌ ±0
118 runs ±0 118 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5425f5c. ± Comparison against base commit 5e1c652.

♻️ This comment has been updated with latest results.

github-actions · 2024-11-20T02:34:46Z

Unit Test Results - Windows

1 files ±0 36 suites ±0 12s ⏱️ ±0s
109 tests ±0 109 ✅ ±0 0 💤 ±0 0 ❌ ±0
118 runs ±0 118 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5425f5c. ± Comparison against base commit 5e1c652.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

jeromy-cannon · 2024-11-21T09:54:20Z

Should this be in draft status? You have it open, not sure if I should be reviewing it. Your description is missing in the PR. You have a lot of merge conflicts, also.

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

…upload-state Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/commands/node/configs.ts # src/commands/node/flags.ts # test/e2e/commands/node_local_hedera.test.ts # test/test_util.ts

github-actions · 2024-11-21T19:21:54Z

E2E Test Report

16 files 109 suites 1h 18m 26s ⏱️
232 tests 232 ✅ 0 💤 0 ❌
235 runs 235 ✅ 0 💤 0 ❌

Results for commit ba0d524.

github-actions · 2024-11-21T19:21:54Z

E2E Test Report

16 files 109 suites 1h 18m 26s ⏱️
232 tests 232 ✅ 0 💤 0 ❌
235 runs 235 ✅ 0 💤 0 ❌

Results for commit ba0d524.

codacy-production · 2024-11-21T19:22:09Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `7fa86ad`¹	✅ 89.71%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`7fa86ad`)	Report Missing	Report Missing	Report Missing
Head commit (`ba0d524`)	14453	12639	87.45%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#849)	136	122	89.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

jeromy-cannon · 2024-11-22T14:41:14Z

README.md.template

@@ -53,17 +58,37 @@ nvm use lts/hydrogen

 * Run `npm install -g @hashgraph/solo`

-## Setup Kubernetes cluster
+## Quick Start Guide
+User can use one of the following three command to quickly deploy a standalone test network.


Nathan I were talking about this. This is more of a quick start for a developer who has checked out our repo and has all of the necessary pre-reqs.

The readme page goes on our npmjs page, and would be misleading, since I don't believe the task command would work out of the box without first installing Task somehow. and then would require everything to be built, etc.

Add instructions to install kind, task and dependencies before using task commands

src/commands/node/tasks.ts

jeromy-cannon · 2024-11-22T14:50:40Z

test/e2e/commands/node_local_hedera.test.ts

  describe('Node for hedera app should have started successfully', () => {
    hederaK8 = bootstrapResp.opts.k8

+    it('save the state and restart the node with saved state', async function () {


are we able to validate that after the state is restored that the new accounts still exist?

Added logic to check account balance after restart from state file

Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas · 2024-11-22T17:21:17Z

Added logic to check account balance after restart from state file

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas added 4 commits November 19, 2024 10:17

fix: node logs command flags

c350527

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Fix: log download path, add unit test

edfe271

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

Add command to download state files

c181db2

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

feat: add flag to upload state

e3ad3ab

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested review from leninmehedy and a team as code owners November 20, 2024 02:31

JeffreyDallas changed the base branch from main to 00847-D-fix-node-logs November 20, 2024 02:32

revert

137f8a5

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

jeromy-cannon assigned JeffreyDallas Nov 20, 2024

Base automatically changed from 00847-D-fix-node-logs to main November 20, 2024 12:59

JeffreyDallas added 2 commits November 21, 2024 08:53

update readme

fd8763f

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

update Readme

2638097

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

JeffreyDallas requested a review from a team as a code owner November 21, 2024 15:24

Merge commit '7fa86ad19c66d2ea98d4d10b0400b1635499c322' into 00817-D-…

ba0d524

…upload-state Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/commands/node/configs.ts # src/commands/node/flags.ts # test/e2e/commands/node_local_hedera.test.ts # test/test_util.ts