Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tfawserr.ErrMessageContains, AWS SDK for Go v2 variant of helper in v2/awsv1shim/tfawserr #533

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 29, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds an AWS SDK for Go v2 variant of the ErrMessageContains helper in v2/awsv1shim/tfawserr.

Relates #524.

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	6.322s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	0.901s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	0.617s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	0.562s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	0.353s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	0.801s

@ewbankkit ewbankkit requested a review from a team as a code owner June 29, 2023 20:34
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants