Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tfawserr.ErrCodeContains, AWS SDK for Go v2 variant of v2/awsv1shim/tfawserr.ErrCodeContains #733

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add tfawserr.ErrCodeContains, AWS SDK for Go v2 variant of v2/awsv1shim/tfawserr.ErrCodeContains #733

merged 1 commit into from
Nov 1, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 1, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds an AWS SDK for Go v2 variant of the ErrCodeContains helper in v2/awsv1shim/tfawserr.

Relates #642.
Relates #524.
Relates #533.

% go test ./tfawserr/...
ok      github.com/hashicorp/aws-sdk-go-base/v2/tfawserr        0.435s

@ewbankkit ewbankkit requested a review from a team as a code owner November 1, 2023 14:33
jar-b
jar-b approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% go test -count=1 ./tfawserr/...
ok      github.com/hashicorp/aws-sdk-go-base/v2/tfawserr        0.393s

@ewbankkit ewbankkit merged commit 1cc5806 into main Nov 1, 2023
7 checks passed
@ewbankkit ewbankkit deleted the f--aws-sdk-go-v2-ErrCodeContains branch November 1, 2023 15:04
@ewbankkit ewbankkit mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @jar-b