This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Update Getting Started guide and script #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly to avoid PodDisruptionBudget deprecation warning fixed in hashicorp/consul-k8s#606
@mikemorris for the yaml breakout question (which I just saw, sorry) -- I'm fine if we want to move them into their own files rather than being inline (that way we'd also avoid the need to create a
|
mikemorris
commented
Oct 27, 2021
mikemorris
force-pushed
the
dev/getting-started
branch
from
October 27, 2021 15:25
c0c654f
to
5ca9ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick thing about verifying the ordering for the kubectl delete
process. If it doesn't work, I'd say just revert to the manually ordered deletion in the markdown directions. If it does, I think this is pretty much good to go.
andrewstucki
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks a few lines to get the quick start running smoothly.
Would it additionally make sense to break out all the inline YAML into separate files?