Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disruptionbudget api version #606

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Update disruptionbudget api version #606

merged 4 commits into from
Aug 20, 2021

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Aug 12, 2021

policy/v1beta1 is deprecated in Kubernetes 1.21+

W0726 17:27:19.007398 4427 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget

How I've tested this PR:

  • installed on a 1.21 kube cluster with/without the change

How I expect reviewers to test this PR:

  • code

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@lkysow lkysow requested review from a team, ndhanushkodi and sadjamz and removed request for a team August 12, 2021 16:17
Copy link
Contributor

@sadjamz sadjamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and good comment on line 135 of the bats test, that was helpful!

@lkysow lkysow merged commit b8e13ec into master Aug 20, 2021
@lkysow lkysow deleted the lkysow/pod-disruption branch August 20, 2021 18:09
mikemorris added a commit to hashicorp/consul-api-gateway that referenced this pull request Oct 25, 2021
Mostly to avoid PodDisruptionBudget deprecation warning fixed in
hashicorp/consul-k8s#606
mikemorris added a commit to hashicorp/consul-api-gateway that referenced this pull request Oct 27, 2021
* dev: run helm repo update after adding hashicorp helm repo

* dev: bump consul helm chart to v0.35.0

Mostly to avoid PodDisruptionBudget deprecation warning fixed in
hashicorp/consul-k8s#606

* dev: tweak quick start instructions, use official HashiCorp Homebrew tap

* dev: clarify Docker Kubernetes not needed

* dev: refactor embedded config into separate yaml files

* dev: add note on expected output of curling the echo container

* dev: update getting started instructions requiring Consul binary

* dev: remove tmp from .gitignore, add bin and pkg/bin
trihoangvo added a commit to opentelekomcloud-blueprints/consul-helm that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants