fix: set initial_fetch_timeout to wait for initial xDS… #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
requested review from
thisisnotashwin
and removed request for
a team and
hashi-derek
DanStough
force-pushed
the
dans/NET-3917/default-0s-initial_fetch_timeout
branch
from
bce9cbb
to
8fd981f
Compare
DanStough
changed the title
zalimeni
approved these changes
May 12, 2023
This was referenced May 15, 2023
chapmanc
pushed a commit
that referenced
this pull request
May 31, 2023
chapmanc
added a commit
that referenced
this pull request
May 31, 2023
Revert #104 and remove fetch timeout for envoy
DanStough
pushed a commit
that referenced
this pull request
Jun 1, 2023
DanStough
added a commit
that referenced
this pull request
Jun 1, 2023
* Revert #104 and remove fetch timeout for envoy * Adding changelog --------- Co-authored-by: Chris Chapman <cchapman@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consul dataplane updates for #17283..
This changes the time Envoy waits for the initial xDS configuration from the default (15s) to indefinitely. This prevents Envoy from starting with only a partial list of listeners/clusters.
Testing & Reproduction steps
Goldenfile tests have been updated since this affects Envoy's bootstrap configuration.