Backport of fix: set initial_fetch_timeout to wait for initial xDS… into release/1.1.x #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-3917/default-0s-initial_fetch_timeout/secondly-live-doberman
branch
from
b6f8620
to
8d111a2
Compare
|
Please go ahead and approve and merge if this looks good! |
DanStough
approved these changes
May 15, 2023
hc-github-team-consul-core
deleted the
backport/dans/NET-3917/default-0s-initial_fetch_timeout/secondly-live-doberman
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #104 to be assessed for backporting due to the inclusion of the label backport/1.1.
The below text is copied from the body of the original PR.
Description
Consul dataplane updates for #17283..
This changes the time Envoy waits for the initial xDS configuration from the default (15s) to indefinitely. This prevents Envoy from starting with only a partial list of listeners/clusters.
Testing & Reproduction steps
Goldenfile tests have been updated since this affects Envoy's bootstrap configuration.
Overview of commits