Skip to content

Commit

Permalink
Include TLSServerName in early return equality check
Browse files Browse the repository at this point in the history
Support for `TLSServerName` was added in #116, but this early return
equality check wasn't updated to include the new field. The impact is
changes to the value of `TLSServerName` aren't picked up by the health
checks unless accompanied by other changes to the check definition.
  • Loading branch information
cbroglie authored and eikenb committed Sep 20, 2022
1 parent 9095511 commit 94d4e98
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions check.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ func (c *CheckRunner) updateCheckHTTP(latestCheck *api.HealthCheck, checkHash ty
reflect.DeepEqual(httpCheck.Header, http.Header) &&
httpCheck.Method == http.Method &&
httpCheck.TLSClientConfig.InsecureSkipVerify == http.TLSClientConfig.InsecureSkipVerify &&
httpCheck.TLSClientConfig.ServerName == http.TLSClientConfig.ServerName &&
httpCheck.Interval == http.Interval &&
httpCheck.Timeout == http.Timeout &&
check.Definition.DeregisterCriticalServiceAfter == definition.DeregisterCriticalServiceAfter {
Expand Down

0 comments on commit 94d4e98

Please sign in to comment.