Add support for TLSServerName for HTTP health checks #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radek Dvořák <radek.dvorak@gmail.com>
|
|
cbroglie
approved these changes
Dec 16, 2021
|
Thanks for submitting this @RadekDvorak! Nice followup with consul having accepted the upstream fixes. And thanks for the code review @cbroglie! I'm new to maintaining this project and am not as familiar with the code. Knowing this does address/fix your issue is good information. |
cbroglie
added a commit
to cbroglie/consul-esm
that referenced
this pull request
Sep 20, 2022
Support for `TLSServerName` was added in hashicorp#116, but this early return equality check wasn't updated to include the new field. The impact is changes to the value of `TLSServerName` aren't picked up by the health checks unless accompanied by other changes to the check definition.
eikenb
pushed a commit
that referenced
this pull request
Sep 20, 2022
Support for `TLSServerName` was added in #116, but this early return equality check wasn't updated to include the new field. The impact is changes to the value of `TLSServerName` aren't picked up by the health checks unless accompanied by other changes to the check definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables custom SNI/TLSServerName for HTTP health checks. This is essentially a followup for #102.