-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom labels for connectInject, acl init, and mesh gateway pods via Helm #759
Comments
Thank you @jeanmorais! I'll ask someone to review later this sprint. You are correct about catalog sync! |
@jeanmorais Apologize for the back and forth, but based on discussion with the team it seems like the better UX is to provide extraLabels as a config that is global which would apply to the pods that the Helm chart deploys. I've updated the issue description based on the UX improvement suggestion. @t-eckert or someone should follow up with you tomorrow with more details for guidance on the PR. |
Closing as mentioned in the PR, a better approach would be to do provide global labels instead. |
Community Note
Is your feature request related to a problem? Please describe.
Feature Description
This tracks a feature request to provide the ability to apply custom K8s labels on component that are deployed by the Consul K8s helm chart (some of which are already available today). The feature request describes the ability to set pod labels globally using a single config i.e.
global.extraLabels
for the Pods that are deployed by the Helm chart.Currently the pods with missing labels include:
catalog syncUse Case(s)
This allows practitioners to clearly organize which components of a Helm chart are deployed via the Consul K8s helm chart for either compliance reasons or for tracking purposes.
Contributions
The text was updated successfully, but these errors were encountered: