Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom labels for connectInject, acl init, and mesh gateway pods via Helm #759

Closed
david-yu opened this issue Oct 4, 2021 · 4 comments
Closed
Labels
hacktoberfest type/enhancement New feature or request

Comments

@david-yu
Copy link
Contributor

david-yu commented Oct 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

Feature Description

This tracks a feature request to provide the ability to apply custom K8s labels on component that are deployed by the Consul K8s helm chart (some of which are already available today). The feature request describes the ability to set pod labels globally using a single config i.e. global.extraLabels for the Pods that are deployed by the Helm chart.

Currently the pods with missing labels include:

  • connect inject
  • catalog sync
  • acl init
  • mesh gw

Use Case(s)

This allows practitioners to clearly organize which components of a Helm chart are deployed via the Consul K8s helm chart for either compliance reasons or for tracking purposes.

Contributions

@david-yu david-yu added type/enhancement New feature or request hacktoberfest labels Oct 4, 2021
@david-yu david-yu changed the title Custom labels for connectInject, catalog sync, acl init, and mesh gateway components Custom labels for connectInject, catalog sync, acl init, and mesh gateway pods Oct 4, 2021
@david-yu david-yu changed the title Custom labels for connectInject, catalog sync, acl init, and mesh gateway pods Custom labels for connectInject, catalog sync, acl init, and mesh gateway pods via Helm Oct 4, 2021
@david-yu david-yu changed the title Custom labels for connectInject, catalog sync, acl init, and mesh gateway pods via Helm Custom labels for connectInject, catalog sync, acl init, and mesh gateway pods via Helm Oct 4, 2021
lawliet89 pushed a commit to lawliet89/consul-k8s that referenced this issue Oct 6, 2021
@jeanmorais
Copy link
Contributor

@david-yu I've opened a PR to solve this issue. I ended up not including the catalog sync as the Deployment already has custom labels (see here).

@david-yu
Copy link
Contributor Author

Thank you @jeanmorais! I'll ask someone to review later this sprint. You are correct about catalog sync!

@david-yu david-yu changed the title Custom labels for connectInject, catalog sync, acl init, and mesh gateway pods via Helm Custom labels for connectInject, acl init, and mesh gateway pods via Helm Oct 10, 2021
@david-yu
Copy link
Contributor Author

david-yu commented Oct 14, 2021

@jeanmorais Apologize for the back and forth, but based on discussion with the team it seems like the better UX is to provide extraLabels as a config that is global which would apply to the pods that the Helm chart deploys. I've updated the issue description based on the UX improvement suggestion. @t-eckert or someone should follow up with you tomorrow with more details for guidance on the PR.

@david-yu
Copy link
Contributor Author

david-yu commented Jun 6, 2022

Closing as mentioned in the PR, a better approach would be to do provide global labels instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants