Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add global.extraLabels values.yaml setting into release/1.0.x #1777

Conversation

hc-github-team-consul-ecosystem
Copy link
Contributor

Backport

This PR is auto-generated from #1771 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Currently, there isn't a way to add a set of labels to every pod (see #759 for example). This PR adds a global values.yaml setting that lets you specify labels to apply to every pod/deployment/daemonset/statefulset/job created by the helm chart. This is in addition to the existing extraLabels config for things like clients and servers.

Changes proposed in this PR:

  • Add in global.extraLabels values.yaml setting
  • Use that setting to apply extra labels to all pods/deployments/daemonsets/statefulsets/jobs created by the consul-k8s helm chart
  • bats tests, I guess

How I've tested this PR:

Added bats tests to cover testing extra labels for all applicable resources

How I expect reviewers to test this PR:

Run the tests, maybe deploy the helm chart locally just to make sure it works

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-ecosystem hc-github-team-consul-ecosystem force-pushed the backport/feature/global-labels/severely-sweeping-wren branch from 4998f81 to 255a9ba Compare December 7, 2022 20:34
@hc-github-team-consul-ecosystem hc-github-team-consul-ecosystem merged commit 828cba3 into release/1.0.x Dec 7, 2022
@hc-github-team-consul-ecosystem hc-github-team-consul-ecosystem deleted the backport/feature/global-labels/severely-sweeping-wren branch December 7, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants