-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Branch: consul-k8s
Envoy Debugging
#1271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
force-pushed
the
cli/envoy-debugging
branch
from
June 22, 2022 18:43
17ecdfa
to
8ef4383
Compare
t-eckert
force-pushed
the
cli/envoy-debugging
branch
from
July 1, 2022 17:22
77e14ed
to
c8f080f
Compare
t-eckert
force-pushed
the
cli/envoy-debugging
branch
from
July 8, 2022 23:23
c8f080f
to
c2ee44d
Compare
t-eckert
force-pushed
the
cli/envoy-debugging
branch
2 times, most recently
from
July 22, 2022 17:01
9aa2280
to
2851b67
Compare
2 tasks
t-eckert
force-pushed
the
cli/envoy-debugging
branch
2 times, most recently
from
August 3, 2022 01:38
fbe5f8f
to
e248068
Compare
t-eckert
requested review from
a team,
ishustava and
thisisnotashwin
and removed request for
a team
August 9, 2022 14:05
t-eckert
commented
Aug 9, 2022
t-eckert
commented
Aug 9, 2022
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
t-eckert
force-pushed
the
cli/envoy-debugging
branch
from
August 9, 2022 15:56
f260f37
to
9a9a55d
Compare
thisisnotashwin
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!! reminder to squash and merge to PR!!
ishustava
approved these changes
Aug 9, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
This feature is based on CSL-196 Consul K8s CLI Envoy Troubleshooting (HashiCorp internal).
Multiple branches will be merged into this branch before the feature is complete. As these parts of the overall feature are merged in, they will be checked off below.
PortForward
struct which enables the CLI to port forwardlocalhost
to Kubernetes Pods.PortForward
struct.consul-k8s proxy list
, to list all Pods which are running Envoy proxies managed by Consul.list
behavior.list
behavior.consul-k8s proxy read podname
, to print a summary of the Envoy configuration for the sidecar running on the given Kubernetes Pod (podname
).read
behavior.read
behavior.How I've tested this PR
read
command as that command uses the port forwarding code.list
command is covered by unit tests and acceptance tests.read
command is covered by unit tests and acceptance tests.How I expect reviewers to test this PR
Installing the CLI from this branch for testing
The version of the CLI on this branch may be installed by cloning the repository and checking out the
cli/envoy-debugging
branch.Checklist