-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update consul-k8s
CLI docs with Envoy Debugging
#13860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, this looks great! i really like the example commands you've added in these docs
a couple of nits, but pre-approving so we can merge along with the k8s release!
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
@im2nguyen, thanks! I figure I should wait to merge this until Thursday? |
Yep! @boruszak is coordinating the other PRs too, do you want him to merge it too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. I added a few grammar and style nits, but otherwise very solid.
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Thomas! Could you also remove the beta notice for the upgrade command as part of this PR?
Description
With the upcoming release of Consul on Kubernetes 0.47.0, the
consul-k8s
CLI will gain two new commands:proxy list
for listing the names of all Pods running Envoy proxies managed by Consul.proxy read <PODNAME>
for inspecting the Envoy configuration of a given Pod.This PR updates the commands page for the
consul-k8s
CLI with documentation for the new commands.In addition, this PR makes some changes to existing documentation with the intent of improving clarity:
Links
PR Checklist
* [ ] updated test coverage (No code added)