remove deprecated annotations in server-service template #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
requested review from
lkysow,
a team and
thisisnotashwin
and removed request for
a team
ishustava
approved these changes
Oct 14, 2022
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
kschoche
deleted the
remove_deprecated_annotatation_from_server_service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"which has been deprecated for 5 years and replaced withspec.publicNotReadyAddresseswhich we also already use.kubernetes/kubernetes#63742
kubernetes/kubernetes#63741
How I've tested this PR:
CI and Unit tests should pass.
Bats test updated.
How I expect reviewers to test this PR:
👀
Checklist: