Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete service.alpha.kubernetes.io/tolerate-unready-endpoints annotation #63741

Closed
thockin opened this issue May 11, 2018 · 0 comments
Closed

Delete service.alpha.kubernetes.io/tolerate-unready-endpoints annotation #63741

thockin opened this issue May 11, 2018 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@thockin
Copy link
Member

thockin commented May 11, 2018

/kind bug

The annotation has been deprecated for 2 releases but it seems its replacement was never implemented.
@thockin thockin added the sig/network Categorizes an issue or PR as relevant to SIG Network. label May 11, 2018
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 11, 2018
@thockin thockin mentioned this issue May 11, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue May 15, 2018
Merge pull request #63742 from thockin/kill-tolerate-unready-annotation
944e074 
Automatic merge from submit-queue (batch tested with PRs 63792, 63495, 63742, 63332, 63779). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Actually support service `publishNotReadyAddresses`

This was added and the annotation was deprecated, but it was never
implemented.

xref #63741

**Release note**:

```release-note
The annotation `service.alpha.kubernetes.io/tolerate-unready-endpoints` is deprecated.  Users should use Service.spec.publishNotReadyAddresses instead.
```
@thockin thockin closed this as completed Jun 7, 2018
@longmuir longmuir mentioned this issue Aug 31, 2018
Merged
BenjaminPelletier added a commit to BenjaminPelletier/dss that referenced this issue Apr 8, 2022
@BenjaminPelletier
Add publishNotReadyAddresses to replace tolerate-unready-endpoints
437486e 
See kubernetes/kubernetes#63741
@BenjaminPelletier BenjaminPelletier mentioned this issue Apr 8, 2022
Merged
BenjaminPelletier added a commit to interuss/dss that referenced this issue Apr 11, 2022
@BenjaminPelletier
[deployment] Add publishNotReadyAddresses to replace tolerate-unready…
942a7cb 
…-endpoints (#762)

See kubernetes/kubernetes#63741: the annotation service.alpha.kubernetes.io/tolerate-unready-endpoints has been replaced by the Service spec argument publishNotReadyAddresses. This PR adds the new spec argument. This is important because CRDB nodes must be able to communicate before they are ready in order to become ready.
@kschoche kschoche mentioned this issue Oct 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thockin @k8s-ci-robot