-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default install and upgrade to "Y" when no answer is given #1673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! very minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should uninstall and upgrade follow the same paradigm of "you typed this command so I am going to default to you wanted to do this" or are we leaving those with N as the default because there is more risk to those?
If the others switch behaviour, suggest baking logic into the |
I could see doing this for upgrade, but the convention is to only auto-yes for "additive" commands. I wouldn't do it for uninstall because it could be a footgun. |
9cac8da
to
bc84340
Compare
Still waiting on @jmurret to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! 🙏
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: