Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default install and upgrade to "Y" when no answer is given #1673

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Default install and upgrade to "Y" when no answer is given #1673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7fe9da
Default install to "Y" when no answer is given
Nov 2, 2022
f58ed89
Add CHANGELOG
Nov 2, 2022
8152ed6
Add comment to approval prompt
Nov 2, 2022
d88c206
Default upgrade to "Y" when no answer is given
Nov 3, 2022
bc84340
Fix underline in upgrade prompt
Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## UNRELEASED

BREAKING_CHANGES:
* CLI:
* Change default behavior of `consul-k8s install` to perform the installation when no answer is provided to the prompt. [[GH-1673](https://github.com/hashicorp/consul-k8s/pull/1673)]
* Helm:
* Remove `global.consulSidecarContainer` from values file as there is no longer a consul sidecar. [[GH-1635](https://github.com/hashicorp/consul-k8s/pull/1635)]
* Consul snapshot-agent now runs as a sidecar with Consul servers. [[GH-1620](https://github.com/hashicorp/consul-k8s/pull/1620)]
Expand Down
4 changes: 2 additions & 2 deletions cli/helm/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ func InstallHelmRelease(options *InstallOptions) error {

if !options.AutoApprove {
confirmation, err := options.UI.Input(&terminal.Input{
Prompt: "Proceed with installation? (y/N)",
Prompt: "Proceed with installation? (Y/n)",
Style: terminal.InfoStyle,
Secret: false,
})

if err != nil {
return err
}
if common.Abort(confirmation) {
if confirmation != "" && common.Abort(confirmation) {
t-eckert marked this conversation as resolved.
Show resolved Hide resolved
options.UI.Output("Install aborted. Use the command `consul-k8s install -help` to learn how to customize your installation.",
terminal.WithInfoStyle())
return err
Expand Down