Backport of Update server-acl-init to always check for the deployed serviceAccountToken secret into release/1.0.x #1905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1770 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
SecretRefs
intoServiceAccounts
(one for service account and the other for docker registry credentials), even in Kubernetes 1.24+. In the current logic ofserver-acl-init
we expect to use the Secret deployed by the helm chart, but only in the case where the ServiceAccount does not contain SecretRefs. Due to OpenShift injecting these we never look for the deployed Secret for the consul-auth-method.How I've tested this PR:
Unit + acceptance tests should pass.
How I expect reviewers to test this PR:
👀
Looking for some review comments about the approach as well :)
Checklist:
Overview of commits