Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 365 days instead of 1 year to account for leap years #1969

Merged
merged 1 commit into from
Mar 2, 2023
Merged

add 365 days instead of 1 year to account for leap years #1969

merged 1 commit into from
Mar 2, 2023

Conversation

wilkermichael
Copy link
Contributor

Changes proposed in this PR:

  • There was an issue where adding 1 year to the time check would fail if it was March 1st because the certificate would be expired Feb 29th. Fixed test to use 365 day increment instead of 1 year increment.

How I've tested this PR:
👀

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • [n/a] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael wilkermichael added the pr/no-changelog PR does not need a corresponding .changelog entry label Mar 1, 2023
@wilkermichael wilkermichael requested review from a team, curtbushko and kyhavlov and removed request for a team March 1, 2023 23:25
@wilkermichael wilkermichael added backport/0.49.x backport/1.1.x Backport to release/1.1.x branch labels Mar 1, 2023
curtbushko
curtbushko approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a weird bug!

@wilkermichael wilkermichael merged commit 968eb42 into main Mar 2, 2023
@wilkermichael wilkermichael deleted the fix-leap-year-test branch March 2, 2023 16:29
This was referenced Mar 2, 2023
Merged
Merged
Merged
absolutelightning pushed a commit that referenced this pull request Aug 4, 2023
@wilkermichael @absolutelightning
add 365 days instead of 1 year to account for leap years (#1969)
c6648a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@curtbushko curtbushko curtbushko approved these changes

@kyhavlov kyhavlov Awaiting requested review from kyhavlov kyhavlov was automatically assigned from hashicorp/consul-core-service-mesh

Assignees
No one assigned
Labels
backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilkermichael @curtbushko @ndhanushkodi