Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of add 365 days instead of 1 year to account for leap years into release/0.49.x #1971

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #1969 to be assessed for backporting due to the inclusion of the label backport/0.49.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • There was an issue where adding 1 year to the time check would fail if it was March 1st because the certificate would be expired Feb 29th. Fixed test to use 365 day increment instead of 1 year increment.

How I've tested this PR:
👀

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • [n/a] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/fix-leap-year-test/severely-working-redfish branch from 367189d to e8f653b Compare March 2, 2023 16:29
@hc-github-team-consul-core hc-github-team-consul-core merged commit 7ab38cb into release/0.49.x Mar 2, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/fix-leap-year-test/severely-working-redfish branch March 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants