Backport of api-gateway: add unit tests verifying scaling parameters on GatewayClassConfig are obeyed into release/1.2.x #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/NET-4319-Unit-Gateway-Deployment-obeys-scaling-parameters-on-GatewayClassConfig/visually-inspired-duck
branch
from
9935ce9
to
d65cef9
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-4319-Unit-Gateway-Deployment-obeys-scaling-parameters-on-GatewayClassConfig/visually-inspired-duck
branch
from
0545969
to
91e7a1d
Compare
nathancoleman
approved these changes
Jun 9, 2023
hc-github-team-consul-core
deleted the
backport/NET-4319-Unit-Gateway-Deployment-obeys-scaling-parameters-on-GatewayClassConfig/visually-inspired-duck
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2272 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
Add unit test coverage ensuring that
Deploymentfor aGatewayhas its replica count clamped to the min + max specified on theGatewayClassConfig.How I've tested this PR:
🤖 tests pass
How I expect reviewers to test this PR:
See above
Checklist:
Overview of commits