-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ENT Tests Now that They Are Running Again 🏃 #3077
Conversation
546d280
to
d72b252
Compare
control-plane/connect-inject/controllers/endpoints/endpoints_controller_ent_test.go
Show resolved
Hide resolved
control-plane/config-entries/controllers/configentry_controller_ent_test.go
Show resolved
Hide resolved
4f35c53
to
ea645bc
Compare
require.Eventually(t, func() bool { | ||
_, _, err := testClient.APIClient.Partitions().Read(context.Background(), constants.DefaultConsulPartition, nil) | ||
if err != nil { | ||
return false | ||
} | ||
return true | ||
}, 5*time.Second, 500*time.Millisecond) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this moves to Consul's sdk
, but it needs to be done in a way that works across V1 and V2 that will require some more thought, more than cleaning up test failure on main
.
There are still flakes in these tests, but it would seem not enough that would prevent them from passing with successive gotestsum runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing these!
control-plane/connect-inject/controllers/peering/peering_acceptor_controller_test.go
Show resolved
Hide resolved
control-plane/config-entries/controllersv2/meshconfig_controller_test.go
Show resolved
Hide resolved
control-plane/connect-inject/controllers/pod/pod_controller_ent_test.go
Outdated
Show resolved
Hide resolved
@zalimeni re: confused emoji: |
6d1561c
to
5f36df8
Compare
Thank you for the context! I was actually just looking for the closest thing to a sad face, bc there are still flakes despite all your efforts here. I think that approach is super reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:chef-kiss:
5f36df8
to
d4c429b
Compare
Looking at some of these failures to lend a hand since they're still looking weird.
Just noting here that this looks like a race w/ the synced buffer underlying My theory is that the reruns of the other failed tests are causing the sync buffer to get out of whack due to reuse. No proof, but hard to otherwise explain how this test is suddenly now impossibly failing. |
7be54ad
to
d4c429b
Compare
d4c429b
to
ffe8248
Compare
Tests are passing now, with @DanStough's fixes and nothing disabled. I believe inconsistent failures came from No-op amended the commit to get a fresh SHA so none of the GHA results were old. |
test: fix tests that are failing on main
test: fix tests that are failing on main
test: fix tests that are failing on main
ENT tests were just turned back on in CI. This revealed some failing test cases. This PR attempts to get everything in working order.