Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix ENT Tests Now that They Are Running Again 🏃 into release/1.0.x #3090

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

zalimeni
Copy link
Member

Backport

This PR is manually generated from #3077 to be assessed for backporting.

The below text is copied from the body of the original PR.


ENT tests were just turned back on in CI. This revealed some failing test cases. This PR attempts to get everything in working order.

test: fix tests that are failing on main
@zalimeni zalimeni added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Oct 17, 2023
@zalimeni zalimeni enabled auto-merge (squash) October 17, 2023 01:49
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We do technically support this version for another couple of weeks. Thanks for backporting!

@zalimeni zalimeni merged commit 098b558 into release/1.0.x Oct 17, 2023
38 of 43 checks passed
@zalimeni zalimeni deleted the backport/1.0.x/dans/fix-enterprise-flakes branch October 17, 2023 14:26
@zalimeni
Copy link
Member Author

LGTM. We do technically support this version for another couple of weeks. Thanks for backporting!

@nathancoleman sure thing! Ran into failures in another PR and realized I needed this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants