Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-5392 Replace dev dependencies w/ latest release tags #3181

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Nov 7, 2023

Changes proposed in this PR:
Some dependencies were previously pinned to utilize unreleased features of the Consul SDK.
This replaces those with the tagged releases containing those features.

In addition, there were some breaking changes in the API submodule that were never released but didn't yet have the consuming end updated in control-plane. I've addressed those as well.

How I've tested this PR:

  • Robot tests pass
  • Visual inspection

How I expect reviewers to test this PR:
See above

Checklist:

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.3.x This release branch is no longer active. labels Nov 7, 2023
@nathancoleman nathancoleman merged commit 173910a into main Nov 7, 2023
28 of 48 checks passed
@nathancoleman nathancoleman deleted the NET-5392-remove-dev-deps-main branch November 7, 2023 22:16
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
* NET-5392 Replace dev dependencies w/ latest release tags

* go mod tidy

* Adjust api-gateway logic based on changes in consul/api

* Stop setting removed field EnvoyExtensions in test

The field was intentionally removed in hashicorp/consul#19186

* gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.3.x This release branch is no longer active. pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants