Backport of Add proxy startup and liveness probe config. into release/1.1.x #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hashi-derek
force-pushed
the
backport/derekm/NET-6858/failure-probe-config/absolutely-refined-lynx
branch
from
9f94bdc
to
a5e759e
Compare
|
Closing and re-opening to trigger CICD again |
This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
hashi-derek
force-pushed
the
backport/derekm/NET-6858/failure-probe-config/absolutely-refined-lynx
branch
from
a5e759e
to
1abfcc6
Compare
hashi-derek
approved these changes
Jan 12, 2024
hashi-derek
deleted the
backport/derekm/NET-6858/failure-probe-config/absolutely-refined-lynx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3450 to be assessed for backporting due to the inclusion of the label backport/1.1.x.
🚨
The person who merged in the original PR is:
@hashi-derek
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
This PR adds in two new
consul.hashicorp.com/sidecar-proxy-startup-failure-secondsandconsul.hashicorp.com/sidecar-proxy-liveness-failure-secondsannotations that are disabled by default.When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
Due to the difficult nature of testing this particular scenario, manual testing was performed on modified consul-server code to ensure that the probes would trigger a restart of the consul-dataplane container when unhealthy.
Overview of commits